Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

John Stultz
2013-12-14T19:54:01Z

On 12/14/2013 11:43 AM, John Stultz wrote:
> On 12/14/2013 09:06 AM, Greg KH wrote:
>> Everything works fine until this one (i.e. the driver doesn't build),
>> but after applying this patch, the build breaks with a ton of undefined
>> symbols at link time, here's a sample of some of them:
>>
>> ERROR: "ion_carveout_heap_destroy" [drivers/staging/android/ion/ion_heap.ko] undefined!
>> ERROR: "ion_chunk_heap_destroy" [drivers/staging/android/ion/ion_heap.ko] undefined!
>> ERROR: "ion_system_heap_create" [drivers/staging/android/ion/ion_heap.ko] undefined!
>> ERROR: "ion_carveout_heap_create" [drivers/staging/android/ion/ion_heap.ko] undefined!
>> ERROR: "ion_system_contig_heap_create" [drivers/staging/android/ion/ion_heap.ko] undefined!
>> ERROR: "ion_cma_heap_create" [drivers/staging/android/ion/ion_heap.ko] undefined!
>> ERROR: "ion_chunk_heap_create" [drivers/staging/android/ion/ion_heap.ko] undefined!
>> ERROR: "ion_buffer_destroy" [drivers/staging/android/ion/ion_heap.ko] undefined!
>> ERROR: "ion_heap_map_user" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!
>> ERROR: "ion_heap_unmap_kernel" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!
>> ERROR: "ion_heap_map_kernel" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!
>> ERROR: "ion_heap_pages_zero" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!
>> ERROR: "ion_pages_sync_for_device" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!
>> ERROR: "ion_buffer_cached" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!
>> ERROR: "ion_heap_buffer_zero" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!
>>
>> So I'm not going to apply this patch, but I have the 115 previous
>> patches (I took your modified 001 patch that you sent off-list to me.)
> ? Hrmm. I'm not seeing this (I wouldn't have sent the patches if I did!).

Ah.. its a problem with make modules. I see it now. Will have a fix for
you shortly.

thanks
-john