Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

John Stultz
2013-12-14T00:53:59Z

On 12/13/2013 03:54 PM, John Stultz wrote:
> On 12/13/2013 03:50 PM, Greg KH wrote:
>> On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote:
>>> From: Rebecca Schultz Zavin <rebecca@android.com>
>>>
>>> Signed-off-by: Rebecca Schultz Zavin <rebecca@android.com>
>>> [jstultz: Squished in Colin Cross' move to staging change]
>>> Signed-off-by: John Stultz <john.stultz@linaro.org>
>>> ---
>>> drivers/staging/android/Kconfig | 2 +
>>> drivers/staging/android/Makefile | 2 +
>> This patch breaks the build if this option is enabled.
>>
>> I suggest only adding the driver to the build _after_ it can be built,
>> for obvious reasons :)
> Right. Until recently it really only builds on ARM. There's a patch
> which adds that dependency (and then later removes it once other fixes
> land), but its later in the patch series.

Ah. Forgot about the shrinker interface changes (which I fix at the very
end).

So yea, I'll disable the config in the first patch ("depends on BROKEN"
good enough? or would you prefer "depends on BROKEN && !BROKEN" to be
really sure? ;), and then yank that line in the last.

thanks
-john