Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

Colin Cross
2013-12-14T21:10:40Z

On Sat, Dec 14, 2013 at 8:52 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote:
>> + idev->debug_root = debugfs_create_dir("ion", NULL);
>> + if (IS_ERR_OR_NULL(idev->debug_root))
>> + pr_err("ion: failed to create debug files.\n");
>
> There's no need to check for this at all, you just printed out an error
> message if CONFIG_DEBUGFS is not enabled, which isn't all that nice.
>
> Something to clean up later, no big deal now.

Patch 75/115 (ion: remove IS_ERR_OR_NULL) replaces this chunk with:
idev->debug_root = debugfs_create_dir("ion", NULL);
if (!idev->debug_root)
pr_err("ion: failed to create debug files.\n");
which won't print an error if debugfs is disabled.