public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/10] Kconfig: cleanup SERIO_I8042 dependencies
@ 2013-12-14 16:59 Mark Salter
  2013-12-14 16:59 ` [PATCH 01/10] alpha: select ARCH_MIGHT_HAVE_PC_SERIO Mark Salter
                   ` (9 more replies)
  0 siblings, 10 replies; 23+ messages in thread
From: Mark Salter @ 2013-12-14 16:59 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Salter

This patch series removes the messy dependencies from SERIO_I8042
by having it depend on one variable (ARCH_MAY_HAVE_PC_SERIO) and
having architectures which need it select that variable in
arch/*/Kconfig.

New architectures are unlikely to need SERIO_I8042, so this avoids
having an ever growing list of architectures to exclude. If an
architecture without i8042 support isn't excluded through the
dependency list for SERIO_I8042 or through explicit disabling in
a config, it will likely panic on boot with something similar to
this (from arm64):

[   27.426181] [<ffffffc000403b1c>] i8042_flush+0x88/0x10c
[   27.426251] [<ffffffc00084cc2c>] i8042_init+0x58/0xe8
[   27.426320] [<ffffffc000080bec>] do_one_initcall+0xc4/0x14c
[   27.426404] [<ffffffc000820970>] kernel_init_freeable+0x1a4/0x244
[   27.426480] [<ffffffc0005a894c>] kernel_init+0x18/0x148
[   27.426561] Code: d2800c82 f2bf7c02 f2dff7e2 f2ffffe2 (39400042) 
[   27.426789] ---[ end trace ac076843cf0f383e ]---
[   27.426875] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b

A tree with these patches is at:

   git://github.com/mosalter/linux.git (serio-i8042 branch)

Mark Salter (10):
  alpha: select ARCH_MIGHT_HAVE_PC_SERIO
  arm: select ARCH_MIGHT_HAVE_PC_SERIO
  ia64: select ARCH_MIGHT_HAVE_PC_SERIO
  mips: select ARCH_MIGHT_HAVE_PC_SERIO
  powerpc: select ARCH_MIGHT_HAVE_PC_SERIO
  sh: select ARCH_MIGHT_HAVE_PC_SERIO
  sparc: select ARCH_MIGHT_HAVE_PC_SERIO
  unicore32: select ARCH_MIGHT_HAVE_PC_SERIO
  x86: select ARCH_MIGHT_HAVE_PC_SERIO
  Kconfig: cleanup SERIO_I8042 dependencies

 arch/alpha/Kconfig          |  1 +
 arch/arm/Kconfig            |  1 +
 arch/ia64/Kconfig           |  1 +
 arch/mips/Kconfig           |  1 +
 arch/powerpc/Kconfig        |  1 +
 arch/sh/Kconfig             |  1 +
 arch/sparc/Kconfig          |  1 +
 arch/unicore32/Kconfig      |  1 +
 arch/x86/Kconfig            |  1 +
 drivers/input/serio/Kconfig | 11 ++++++++---
 10 files changed, 17 insertions(+), 3 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 01/10] alpha: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 [PATCH 00/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
@ 2013-12-14 16:59 ` Mark Salter
  2013-12-15  8:21   ` Matt Turner
  2013-12-14 16:59 ` [PATCH 02/10] arm: " Mark Salter
                   ` (8 subsequent siblings)
  9 siblings, 1 reply; 23+ messages in thread
From: Mark Salter @ 2013-12-14 16:59 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Salter, Richard Henderson, linux-alpha

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.

Signed-off-by: Mark Salter <msalter@redhat.com>
CC: Richard Henderson <rth@twiddle.net>
CC: linux-alpha@vger.kernel.org
---
 arch/alpha/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/alpha/Kconfig b/arch/alpha/Kconfig
index d39dc9b..7ce5ce5 100644
--- a/arch/alpha/Kconfig
+++ b/arch/alpha/Kconfig
@@ -2,6 +2,7 @@ config ALPHA
 	bool
 	default y
 	select ARCH_MIGHT_HAVE_PC_PARPORT
+	select ARCH_MIGHT_HAVE_PC_SERIO
 	select HAVE_AOUT
 	select HAVE_IDE
 	select HAVE_OPROFILE
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 02/10] arm: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 [PATCH 00/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
  2013-12-14 16:59 ` [PATCH 01/10] alpha: select ARCH_MIGHT_HAVE_PC_SERIO Mark Salter
@ 2013-12-14 16:59 ` Mark Salter
  2013-12-14 18:41   ` Russell King - ARM Linux
  2013-12-14 16:59 ` [PATCH 03/10] ia64: " Mark Salter
                   ` (7 subsequent siblings)
  9 siblings, 1 reply; 23+ messages in thread
From: Mark Salter @ 2013-12-14 16:59 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Salter, Russell King, linux-arm-kernel

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.

Signed-off-by: Mark Salter <msalter@redhat.com>
CC: Russell King <linux@arm.linux.org.uk>
CC: linux-arm-kernel@lists.infradead.org
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index c1f1a7e..6990dc5 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -6,6 +6,7 @@ config ARM
 	select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
 	select ARCH_HAVE_CUSTOM_GPIO_H
 	select ARCH_MIGHT_HAVE_PC_PARPORT
+	select ARCH_MIGHT_HAVE_PC_SERIO if FOOTBRIDGE_HOST
 	select ARCH_USE_CMPXCHG_LOCKREF
 	select ARCH_WANT_IPC_PARSE_VERSION
 	select BUILDTIME_EXTABLE_SORT if MMU
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 03/10] ia64: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 [PATCH 00/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
  2013-12-14 16:59 ` [PATCH 01/10] alpha: select ARCH_MIGHT_HAVE_PC_SERIO Mark Salter
  2013-12-14 16:59 ` [PATCH 02/10] arm: " Mark Salter
@ 2013-12-14 16:59 ` Mark Salter
  2013-12-14 16:59 ` [PATCH 04/10] mips: " Mark Salter
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 23+ messages in thread
From: Mark Salter @ 2013-12-14 16:59 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Salter, Tony Luck, Fenghua Yu, linux-ia64

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.

Signed-off-by: Mark Salter <msalter@redhat.com>
CC: Tony Luck <tony.luck@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>
CC: linux-ia64@vger.kernel.org
---
 arch/ia64/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
index 4e4119b..f7337aa 100644
--- a/arch/ia64/Kconfig
+++ b/arch/ia64/Kconfig
@@ -7,6 +7,7 @@ menu "Processor type and features"
 config IA64
 	bool
 	select ARCH_MIGHT_HAVE_PC_PARPORT
+	select ARCH_MIGHT_HAVE_PC_SERIO
 	select PCI if (!IA64_HP_SIM)
 	select ACPI if (!IA64_HP_SIM)
 	select PM if (!IA64_HP_SIM)
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 04/10] mips: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 [PATCH 00/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
                   ` (2 preceding siblings ...)
  2013-12-14 16:59 ` [PATCH 03/10] ia64: " Mark Salter
@ 2013-12-14 16:59 ` Mark Salter
  2013-12-16 16:24   ` Ralf Baechle
  2013-12-14 16:59 ` [PATCH 05/10] powerpc: " Mark Salter
                   ` (5 subsequent siblings)
  9 siblings, 1 reply; 23+ messages in thread
From: Mark Salter @ 2013-12-14 16:59 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Salter, Ralf Baechle, linux-mips

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.

Signed-off-by: Mark Salter <msalter@redhat.com>
CC: Ralf Baechle <ralf@linux-mips.org>
CC: linux-mips@linux-mips.org
---
 arch/mips/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 650de39..99db162 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2,6 +2,7 @@ config MIPS
 	bool
 	default y
 	select ARCH_MIGHT_HAVE_PC_PARPORT
+	select ARCH_MIGHT_HAVE_PC_SERIO
 	select HAVE_CONTEXT_TRACKING
 	select HAVE_GENERIC_DMA_COHERENT
 	select HAVE_IDE
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 05/10] powerpc: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 [PATCH 00/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
                   ` (3 preceding siblings ...)
  2013-12-14 16:59 ` [PATCH 04/10] mips: " Mark Salter
@ 2013-12-14 16:59 ` Mark Salter
  2013-12-14 16:59 ` [PATCH 06/10] sh: " Mark Salter
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 23+ messages in thread
From: Mark Salter @ 2013-12-14 16:59 UTC (permalink / raw)
  To: linux-kernel
  Cc: Mark Salter, Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.

Signed-off-by: Mark Salter <msalter@redhat.com>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: linuxppc-dev@lists.ozlabs.org
---
 arch/powerpc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index b44b52c..fb75485 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -86,6 +86,7 @@ config PPC
 	bool
 	default y
 	select ARCH_MIGHT_HAVE_PC_PARPORT
+	select ARCH_MIGHT_HAVE_PC_SERIO
 	select BINFMT_ELF
 	select OF
 	select OF_EARLY_FLATTREE
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 06/10] sh: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 [PATCH 00/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
                   ` (4 preceding siblings ...)
  2013-12-14 16:59 ` [PATCH 05/10] powerpc: " Mark Salter
@ 2013-12-14 16:59 ` Mark Salter
  2013-12-14 16:59 ` [PATCH 07/10] sparc: " Mark Salter
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 23+ messages in thread
From: Mark Salter @ 2013-12-14 16:59 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Salter, Paul Mundt, linux-sh

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.

Signed-off-by: Mark Salter <msalter@redhat.com>
CC: Paul Mundt <lethal@linux-sh.org>
CC: linux-sh@vger.kernel.org
---
 arch/sh/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
index 9b0979f..3490fc2 100644
--- a/arch/sh/Kconfig
+++ b/arch/sh/Kconfig
@@ -1,6 +1,7 @@
 config SUPERH
 	def_bool y
 	select ARCH_MIGHT_HAVE_PC_PARPORT
+	select ARCH_MIGHT_HAVE_PC_SERIO if SH_CAYMAN
 	select EXPERT
 	select CLKDEV_LOOKUP
 	select HAVE_IDE if HAS_IOPORT
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 07/10] sparc: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 [PATCH 00/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
                   ` (5 preceding siblings ...)
  2013-12-14 16:59 ` [PATCH 06/10] sh: " Mark Salter
@ 2013-12-14 16:59 ` Mark Salter
  2013-12-15  3:29   ` David Miller
  2013-12-14 16:59 ` [PATCH 08/10] unicore32: " Mark Salter
                   ` (2 subsequent siblings)
  9 siblings, 1 reply; 23+ messages in thread
From: Mark Salter @ 2013-12-14 16:59 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Salter, David S. Miller, sparclinux

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.

Signed-off-by: Mark Salter <msalter@redhat.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: sparclinux@vger.kernel.org
---
 arch/sparc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index d4f7a6a..034a680 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -13,6 +13,7 @@ config SPARC
 	bool
 	default y
 	select ARCH_MIGHT_HAVE_PC_PARPORT if SPARC64 && PCI
+	select ARCH_MIGHT_HAVE_PC_SERIO
 	select OF
 	select OF_PROMTREE
 	select HAVE_IDE
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 08/10] unicore32: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 [PATCH 00/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
                   ` (6 preceding siblings ...)
  2013-12-14 16:59 ` [PATCH 07/10] sparc: " Mark Salter
@ 2013-12-14 16:59 ` Mark Salter
  2013-12-16  5:15   ` 回复: " 管雪涛
  2013-12-14 16:59 ` [PATCH 09/10] x86: " Mark Salter
  2013-12-14 16:59 ` [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
  9 siblings, 1 reply; 23+ messages in thread
From: Mark Salter @ 2013-12-14 16:59 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Salter, Guan Xuetao

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.

Signed-off-by: Mark Salter <msalter@redhat.com>
CC: Guan Xuetao <gxt@mprc.pku.edu.cn>
---
 arch/unicore32/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig
index a7ba27b..25c0dba 100644
--- a/arch/unicore32/Kconfig
+++ b/arch/unicore32/Kconfig
@@ -1,6 +1,7 @@
 config UNICORE32
 	def_bool y
 	select ARCH_MIGHT_HAVE_PC_PARPORT
+	select ARCH_MIGHT_HAVE_PC_SERIO
 	select HAVE_MEMBLOCK
 	select HAVE_GENERIC_DMA_COHERENT
 	select HAVE_DMA_ATTRS
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 09/10] x86: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 [PATCH 00/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
                   ` (7 preceding siblings ...)
  2013-12-14 16:59 ` [PATCH 08/10] unicore32: " Mark Salter
@ 2013-12-14 16:59 ` Mark Salter
  2013-12-14 18:32   ` H. Peter Anvin
  2013-12-14 16:59 ` [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
  9 siblings, 1 reply; 23+ messages in thread
From: Mark Salter @ 2013-12-14 16:59 UTC (permalink / raw)
  To: linux-kernel
  Cc: Mark Salter, Ingo Molnar, Thomas Gleixner, H. Peter Anvin, x86

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.

Signed-off-by: Mark Salter <msalter@redhat.com>
CC: Ingo Molnar <mingo@redhat.com>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: x86@kernel.org
---
 arch/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index e903c71..b7f0903 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -23,6 +23,7 @@ config X86
 	def_bool y
 	select ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS
 	select ARCH_MIGHT_HAVE_PC_PARPORT
+	select ARCH_MIGHT_HAVE_PC_SERIO
 	select HAVE_AOUT if X86_32
 	select HAVE_UNSTABLE_SCHED_CLOCK
 	select ARCH_SUPPORTS_NUMA_BALANCING
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies
  2013-12-14 16:59 [PATCH 00/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
                   ` (8 preceding siblings ...)
  2013-12-14 16:59 ` [PATCH 09/10] x86: " Mark Salter
@ 2013-12-14 16:59 ` Mark Salter
  2013-12-14 18:32   ` H. Peter Anvin
  2013-12-16 16:23   ` Ralf Baechle
  9 siblings, 2 replies; 23+ messages in thread
From: Mark Salter @ 2013-12-14 16:59 UTC (permalink / raw)
  To: linux-kernel
  Cc: Mark Salter, Dmitry Torokhov, Richard Henderson, linux-alpha,
	Russell King, linux-arm-kernel, Tony Luck, Fenghua Yu, linux-ia64,
	Ralf Baechle, linux-mips, Benjamin Herrenschmidt, Paul Mackerras,
	linuxppc-dev, Paul Mundt, linux-sh, David S. Miller, sparclinux,
	Guan Xuetao, Ingo Molnar, Thomas Gleixner, H. Peter Anvin, x86

Remove messy dependencies from SERIO_I8042 by having it depend on one
Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures
which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig.
New architectures are unlikely to need SERIO_I8042, so this avoids
having an ever growing list of architectures to exclude.

Signed-off-by: Mark Salter <msalter@redhat.com>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Richard Henderson <rth@twiddle.net>
CC: linux-alpha@vger.kernel.org
CC: Russell King <linux@arm.linux.org.uk>
CC: linux-arm-kernel@lists.infradead.org
CC: Tony Luck <tony.luck@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>
CC: linux-ia64@vger.kernel.org
CC: Ralf Baechle <ralf@linux-mips.org>
CC: linux-mips@linux-mips.org
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: linuxppc-dev@lists.ozlabs.org
CC: Paul Mundt <lethal@linux-sh.org>
CC: linux-sh@vger.kernel.org
CC: "David S. Miller" <davem@davemloft.net>
CC: sparclinux@vger.kernel.org
CC: Guan Xuetao <gxt@mprc.pku.edu.cn>
CC: Ingo Molnar <mingo@redhat.com>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: x86@kernel.org
---
 drivers/input/serio/Kconfig | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig
index 8541f94..1f5cec2 100644
--- a/drivers/input/serio/Kconfig
+++ b/drivers/input/serio/Kconfig
@@ -16,14 +16,19 @@ config SERIO
 	  To compile this driver as a module, choose M here: the
 	  module will be called serio.
 
+config ARCH_MIGHT_HAVE_PC_SERIO
+	bool
+	help
+	  Select this config option from the architecture Kconfig if
+	  the architecture might use a PC serio device (i8042) to
+          communicate with keyboard, mouse, etc.
+
 if SERIO
 
 config SERIO_I8042
 	tristate "i8042 PC Keyboard controller"
 	default y
-	depends on !PARISC && (!ARM || FOOTBRIDGE_HOST) && \
-		   (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN && !S390 && \
-		   !ARC
+	depends on ARCH_MIGHT_HAVE_PC_SERIO
 	help
 	  i8042 is the chip over which the standard AT keyboard and PS/2
 	  mouse are connected to the computer. If you use these devices,
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH 09/10] x86: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 ` [PATCH 09/10] x86: " Mark Salter
@ 2013-12-14 18:32   ` H. Peter Anvin
  0 siblings, 0 replies; 23+ messages in thread
From: H. Peter Anvin @ 2013-12-14 18:32 UTC (permalink / raw)
  To: Mark Salter, linux-kernel; +Cc: Ingo Molnar, Thomas Gleixner, x86

On 12/14/2013 08:59 AM, Mark Salter wrote:
> Architectures which might use an i8042 for serial IO to keyboard,
> mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.
> 
> Signed-off-by: Mark Salter <msalter@redhat.com>
> CC: Ingo Molnar <mingo@redhat.com>
> CC: Thomas Gleixner <tglx@linutronix.de>
> CC: "H. Peter Anvin" <hpa@zytor.com>
> CC: x86@kernel.org
> ---
>  arch/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index e903c71..b7f0903 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -23,6 +23,7 @@ config X86
>  	def_bool y
>  	select ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS
>  	select ARCH_MIGHT_HAVE_PC_PARPORT
> +	select ARCH_MIGHT_HAVE_PC_SERIO
>  	select HAVE_AOUT if X86_32
>  	select HAVE_UNSTABLE_SCHED_CLOCK
>  	select ARCH_SUPPORTS_NUMA_BALANCING
> 

Acked-by: H. Peter Anvin <hpa@linux.intel.com>


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies
  2013-12-14 16:59 ` [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
@ 2013-12-14 18:32   ` H. Peter Anvin
  2013-12-15 10:36     ` Dmitry Torokhov
  2013-12-16 16:23   ` Ralf Baechle
  1 sibling, 1 reply; 23+ messages in thread
From: H. Peter Anvin @ 2013-12-14 18:32 UTC (permalink / raw)
  To: Mark Salter, linux-kernel
  Cc: Dmitry Torokhov, Richard Henderson, linux-alpha, Russell King,
	linux-arm-kernel, Tony Luck, Fenghua Yu, linux-ia64, Ralf Baechle,
	linux-mips, Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev,
	Paul Mundt, linux-sh, David S. Miller, sparclinux, Guan Xuetao,
	Ingo Molnar, Thomas Gleixner, x86

On 12/14/2013 08:59 AM, Mark Salter wrote:
> Remove messy dependencies from SERIO_I8042 by having it depend on one
> Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures
> which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig.
> New architectures are unlikely to need SERIO_I8042, so this avoids
> having an ever growing list of architectures to exclude.
> 
> Signed-off-by: Mark Salter <msalter@redhat.com>
> CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> CC: Richard Henderson <rth@twiddle.net>
> CC: linux-alpha@vger.kernel.org
> CC: Russell King <linux@arm.linux.org.uk>
> CC: linux-arm-kernel@lists.infradead.org
> CC: Tony Luck <tony.luck@intel.com>
> CC: Fenghua Yu <fenghua.yu@intel.com>
> CC: linux-ia64@vger.kernel.org
> CC: Ralf Baechle <ralf@linux-mips.org>
> CC: linux-mips@linux-mips.org
> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> CC: Paul Mackerras <paulus@samba.org>
> CC: linuxppc-dev@lists.ozlabs.org
> CC: Paul Mundt <lethal@linux-sh.org>
> CC: linux-sh@vger.kernel.org
> CC: "David S. Miller" <davem@davemloft.net>
> CC: sparclinux@vger.kernel.org
> CC: Guan Xuetao <gxt@mprc.pku.edu.cn>
> CC: Ingo Molnar <mingo@redhat.com>
> CC: Thomas Gleixner <tglx@linutronix.de>
> CC: "H. Peter Anvin" <hpa@zytor.com>
> CC: x86@kernel.org

Acked-by: H. Peter Anvin <hpa@linux.intel.com>



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 02/10] arm: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 ` [PATCH 02/10] arm: " Mark Salter
@ 2013-12-14 18:41   ` Russell King - ARM Linux
  0 siblings, 0 replies; 23+ messages in thread
From: Russell King - ARM Linux @ 2013-12-14 18:41 UTC (permalink / raw)
  To: Mark Salter; +Cc: linux-kernel, linux-arm-kernel

On Sat, Dec 14, 2013 at 11:59:28AM -0500, Mark Salter wrote:
> Architectures which might use an i8042 for serial IO to keyboard,
> mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.
> 
> Signed-off-by: Mark Salter <msalter@redhat.com>
> CC: Russell King <linux@arm.linux.org.uk>
> CC: linux-arm-kernel@lists.infradead.org
> ---
>  arch/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index c1f1a7e..6990dc5 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -6,6 +6,7 @@ config ARM
>  	select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
>  	select ARCH_HAVE_CUSTOM_GPIO_H
>  	select ARCH_MIGHT_HAVE_PC_PARPORT
> +	select ARCH_MIGHT_HAVE_PC_SERIO if FOOTBRIDGE_HOST
>  	select ARCH_USE_CMPXCHG_LOCKREF
>  	select ARCH_WANT_IPC_PARSE_VERSION
>  	select BUILDTIME_EXTABLE_SORT if MMU

It would be better to put this in arch/arm/mach-footbridge/Kconfig -
ARM is impled as being true there.

Thanks.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 07/10] sparc: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 ` [PATCH 07/10] sparc: " Mark Salter
@ 2013-12-15  3:29   ` David Miller
  0 siblings, 0 replies; 23+ messages in thread
From: David Miller @ 2013-12-15  3:29 UTC (permalink / raw)
  To: msalter; +Cc: linux-kernel, sparclinux

From: Mark Salter <msalter@redhat.com>
Date: Sat, 14 Dec 2013 11:59:33 -0500

> Architectures which might use an i8042 for serial IO to keyboard,
> mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.
> 
> Signed-off-by: Mark Salter <msalter@redhat.com>

Acked-by: David S. Miller <davem@davemloft.net>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 01/10] alpha: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 ` [PATCH 01/10] alpha: select ARCH_MIGHT_HAVE_PC_SERIO Mark Salter
@ 2013-12-15  8:21   ` Matt Turner
  0 siblings, 0 replies; 23+ messages in thread
From: Matt Turner @ 2013-12-15  8:21 UTC (permalink / raw)
  To: Mark Salter; +Cc: LKML, Richard Henderson, linux-alpha

Acked-by: Matt Turner <mattst88@gmail.com>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies
  2013-12-14 18:32   ` H. Peter Anvin
@ 2013-12-15 10:36     ` Dmitry Torokhov
  2013-12-15 15:50       ` Mark Salter
  0 siblings, 1 reply; 23+ messages in thread
From: Dmitry Torokhov @ 2013-12-15 10:36 UTC (permalink / raw)
  To: H. Peter Anvin
  Cc: Mark Salter, linux-kernel, Richard Henderson, linux-alpha,
	Russell King, linux-arm-kernel, Tony Luck, Fenghua Yu, linux-ia64,
	Ralf Baechle, linux-mips, Benjamin Herrenschmidt, Paul Mackerras,
	linuxppc-dev, Paul Mundt, linux-sh, David S. Miller, sparclinux,
	Guan Xuetao, Ingo Molnar, Thomas Gleixner, x86

On Sat, Dec 14, 2013 at 10:32:31AM -0800, H. Peter Anvin wrote:
> On 12/14/2013 08:59 AM, Mark Salter wrote:
> > Remove messy dependencies from SERIO_I8042 by having it depend on one
> > Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures
> > which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig.
> > New architectures are unlikely to need SERIO_I8042, so this avoids
> > having an ever growing list of architectures to exclude.
> > 
> > Signed-off-by: Mark Salter <msalter@redhat.com>
> > CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > CC: Richard Henderson <rth@twiddle.net>
> > CC: linux-alpha@vger.kernel.org
> > CC: Russell King <linux@arm.linux.org.uk>
> > CC: linux-arm-kernel@lists.infradead.org
> > CC: Tony Luck <tony.luck@intel.com>
> > CC: Fenghua Yu <fenghua.yu@intel.com>
> > CC: linux-ia64@vger.kernel.org
> > CC: Ralf Baechle <ralf@linux-mips.org>
> > CC: linux-mips@linux-mips.org
> > CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > CC: Paul Mackerras <paulus@samba.org>
> > CC: linuxppc-dev@lists.ozlabs.org
> > CC: Paul Mundt <lethal@linux-sh.org>
> > CC: linux-sh@vger.kernel.org
> > CC: "David S. Miller" <davem@davemloft.net>
> > CC: sparclinux@vger.kernel.org
> > CC: Guan Xuetao <gxt@mprc.pku.edu.cn>
> > CC: Ingo Molnar <mingo@redhat.com>
> > CC: Thomas Gleixner <tglx@linutronix.de>
> > CC: "H. Peter Anvin" <hpa@zytor.com>
> > CC: x86@kernel.org
> 
> Acked-by: H. Peter Anvin <hpa@linux.intel.com>

How are we going to merge this? In bulk through input tree or peacemeal
through all arches first?

-- 
Dmitry

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies
  2013-12-15 10:36     ` Dmitry Torokhov
@ 2013-12-15 15:50       ` Mark Salter
  2013-12-16  1:27         ` David Miller
  0 siblings, 1 reply; 23+ messages in thread
From: Mark Salter @ 2013-12-15 15:50 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: H. Peter Anvin, linux-kernel, Richard Henderson, linux-alpha,
	Russell King, linux-arm-kernel, Tony Luck, Fenghua Yu, linux-ia64,
	Ralf Baechle, linux-mips, Benjamin Herrenschmidt, Paul Mackerras,
	linuxppc-dev, Paul Mundt, linux-sh, David S. Miller, sparclinux,
	Guan Xuetao, Ingo Molnar, Thomas Gleixner, x86

On Sun, 2013-12-15 at 02:36 -0800, Dmitry Torokhov wrote:
> On Sat, Dec 14, 2013 at 10:32:31AM -0800, H. Peter Anvin wrote:
> > On 12/14/2013 08:59 AM, Mark Salter wrote:
> > > Remove messy dependencies from SERIO_I8042 by having it depend on one
> > > Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures
> > > which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig.
> > > New architectures are unlikely to need SERIO_I8042, so this avoids
> > > having an ever growing list of architectures to exclude.

> How are we going to merge this? In bulk through input tree or peacemeal
> through all arches first?
> 

They should all go together to eliminate the chance of bisect breakage.
Either the input tree or maybe akpm tree.



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies
  2013-12-15 15:50       ` Mark Salter
@ 2013-12-16  1:27         ` David Miller
  2013-12-16  4:59           ` Dmitry Torokhov
  0 siblings, 1 reply; 23+ messages in thread
From: David Miller @ 2013-12-16  1:27 UTC (permalink / raw)
  To: msalter
  Cc: dmitry.torokhov, hpa, linux-kernel, rth, linux-alpha, linux,
	linux-arm-kernel, tony.luck, fenghua.yu, linux-ia64, ralf,
	linux-mips, benh, paulus, linuxppc-dev, lethal, linux-sh,
	sparclinux, gxt, mingo, tglx, x86

From: Mark Salter <msalter@redhat.com>
Date: Sun, 15 Dec 2013 10:50:26 -0500

> On Sun, 2013-12-15 at 02:36 -0800, Dmitry Torokhov wrote:
>> How are we going to merge this? In bulk through input tree or peacemeal
>> through all arches first?
>
> They should all go together to eliminate the chance of bisect breakage.
> Either the input tree or maybe akpm tree.

This sounds good to me.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies
  2013-12-16  1:27         ` David Miller
@ 2013-12-16  4:59           ` Dmitry Torokhov
  0 siblings, 0 replies; 23+ messages in thread
From: Dmitry Torokhov @ 2013-12-16  4:59 UTC (permalink / raw)
  To: David Miller
  Cc: msalter, hpa, linux-kernel, rth, linux-alpha, linux,
	linux-arm-kernel, tony.luck, fenghua.yu, linux-ia64, ralf,
	linux-mips, benh, paulus, linuxppc-dev, lethal, linux-sh,
	sparclinux, gxt, mingo, tglx, x86

On Sun, Dec 15, 2013 at 08:27:25PM -0500, David Miller wrote:
> From: Mark Salter <msalter@redhat.com>
> Date: Sun, 15 Dec 2013 10:50:26 -0500
> 
> > On Sun, 2013-12-15 at 02:36 -0800, Dmitry Torokhov wrote:
> >> How are we going to merge this? In bulk through input tree or peacemeal
> >> through all arches first?
> >
> > They should all go together to eliminate the chance of bisect breakage.
> > Either the input tree or maybe akpm tree.
> 
> This sounds good to me.

OK, then I'll pick it up once I collect more acks from the arch
maintainers.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 23+ messages in thread

* 回复: [PATCH 08/10] unicore32: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 ` [PATCH 08/10] unicore32: " Mark Salter
@ 2013-12-16  5:15   ` 管雪涛
  0 siblings, 0 replies; 23+ messages in thread
From: 管雪涛 @ 2013-12-16  5:15 UTC (permalink / raw)
  To: Mark Salter; +Cc: linux-kernel, Guan Xuetao

It's ok to unicore32.

Acked-by: Guan Xuetao <gxt@mprc.pku.edu.cn>

----- Mark Salter <msalter@redhat.com> 写道:
> Architectures which might use an i8042 for serial IO to keyboard,
> mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.
> 
> Signed-off-by: Mark Salter <msalter@redhat.com>
> CC: Guan Xuetao <gxt@mprc.pku.edu.cn>
> ---
>  arch/unicore32/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig
> index a7ba27b..25c0dba 100644
> --- a/arch/unicore32/Kconfig
> +++ b/arch/unicore32/Kconfig
> @@ -1,6 +1,7 @@
>  config UNICORE32
>  	def_bool y
>  	select ARCH_MIGHT_HAVE_PC_PARPORT
> +	select ARCH_MIGHT_HAVE_PC_SERIO
>  	select HAVE_MEMBLOCK
>  	select HAVE_GENERIC_DMA_COHERENT
>  	select HAVE_DMA_ATTRS
> -- 
> 1.8.3.1
> 


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies
  2013-12-14 16:59 ` [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
  2013-12-14 18:32   ` H. Peter Anvin
@ 2013-12-16 16:23   ` Ralf Baechle
  1 sibling, 0 replies; 23+ messages in thread
From: Ralf Baechle @ 2013-12-16 16:23 UTC (permalink / raw)
  To: Mark Salter
  Cc: linux-kernel, Dmitry Torokhov, Richard Henderson, linux-alpha,
	Russell King, linux-arm-kernel, Tony Luck, Fenghua Yu, linux-ia64,
	linux-mips, Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev,
	Paul Mundt, linux-sh, David S. Miller, sparclinux, Guan Xuetao,
	Ingo Molnar, Thomas Gleixner, H. Peter Anvin, x86

On Sat, Dec 14, 2013 at 11:59:36AM -0500, Mark Salter wrote:

> -	depends on !PARISC && (!ARM || FOOTBRIDGE_HOST) && \
> -		   (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN && !S390 && \
> -		   !ARC
> +	depends on ARCH_MIGHT_HAVE_PC_SERIO

Most dependencies on an architecture's kconfig symbol outside arch/
should probably be treated as a bug.

Acked-by: Ralf Baechle <ralf@linux-mips.org>

  Ralf

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 04/10] mips: select ARCH_MIGHT_HAVE_PC_SERIO
  2013-12-14 16:59 ` [PATCH 04/10] mips: " Mark Salter
@ 2013-12-16 16:24   ` Ralf Baechle
  0 siblings, 0 replies; 23+ messages in thread
From: Ralf Baechle @ 2013-12-16 16:24 UTC (permalink / raw)
  To: Mark Salter; +Cc: linux-kernel, linux-mips

Acked-by: Ralf Baechle <ralf@linux-mips.org>

Thanks,

  Ralf

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2013-12-16 16:25 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-14 16:59 [PATCH 00/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
2013-12-14 16:59 ` [PATCH 01/10] alpha: select ARCH_MIGHT_HAVE_PC_SERIO Mark Salter
2013-12-15  8:21   ` Matt Turner
2013-12-14 16:59 ` [PATCH 02/10] arm: " Mark Salter
2013-12-14 18:41   ` Russell King - ARM Linux
2013-12-14 16:59 ` [PATCH 03/10] ia64: " Mark Salter
2013-12-14 16:59 ` [PATCH 04/10] mips: " Mark Salter
2013-12-16 16:24   ` Ralf Baechle
2013-12-14 16:59 ` [PATCH 05/10] powerpc: " Mark Salter
2013-12-14 16:59 ` [PATCH 06/10] sh: " Mark Salter
2013-12-14 16:59 ` [PATCH 07/10] sparc: " Mark Salter
2013-12-15  3:29   ` David Miller
2013-12-14 16:59 ` [PATCH 08/10] unicore32: " Mark Salter
2013-12-16  5:15   ` 回复: " 管雪涛
2013-12-14 16:59 ` [PATCH 09/10] x86: " Mark Salter
2013-12-14 18:32   ` H. Peter Anvin
2013-12-14 16:59 ` [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter
2013-12-14 18:32   ` H. Peter Anvin
2013-12-15 10:36     ` Dmitry Torokhov
2013-12-15 15:50       ` Mark Salter
2013-12-16  1:27         ` David Miller
2013-12-16  4:59           ` Dmitry Torokhov
2013-12-16 16:23   ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox