public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Cohen <david.a.cohen@linux.intel.com>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org
Cc: linux-kernel@vger.kernel.org,
	David Cohen <david.a.cohen@linux.intel.com>
Subject: [PATCH] x86: intel-mid: make X86_INTEL_MID depending on SFI
Date: Sat, 14 Dec 2013 11:23:24 -0800	[thread overview]
Message-ID: <1387049004-21622-1-git-send-email-david.a.cohen@linux.intel.com> (raw)

Despite our intention to not make Intel MID dependent of SFI, it does
not reflect the current situation.
If SFI is not selected, Intel MID can't select APB_TIMER otherwise this
happens:

arch/x86/built-in.o: In function `apbt_set_mapping':
arch/x86/kernel/apb_timer.c:91: undefined reference to `sfi_get_mtmr'
arch/x86/kernel/apb_timer.c:109: undefined reference to `sfi_free_mtmr'
arch/x86/kernel/apb_timer.c:112: undefined reference to `sfi_get_mtmr'
arch/x86/kernel/apb_timer.c:91: undefined reference to `sfi_get_mtmr'
arch/x86/kernel/apb_timer.c:109: undefined reference to `sfi_free_mtmr'
arch/x86/kernel/apb_timer.c:112: undefined reference to `sfi_get_mtmr'

This patch solves such problem by adding SFI as dependence of
X86_INTEL_MID. As soon as we make Intel MID completely independent of
SFI this patch is safe to be reverted.

Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
---

This patch is intended to be applied on kernel 3.13-rc release.

As a matter of curiosity, CONFIG_APB_TIMER does depend on CONFIG_SFI. But looks
like CONFIG_X86_INTEL_MID is able to bypass it.
Maybe we need to check Kconfig itself too?

 arch/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 00fa3b7d2abe..5802476d4e91 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -447,6 +447,7 @@ config X86_INTEL_MID
 	depends on PCI
 	depends on PCI_GOANY
 	depends on X86_IO_APIC
+	depends on SFI
 	select DW_APB_TIMER
 	select APB_TIMER
 	select INTEL_SCU_IPC
-- 
1.8.4.2


             reply	other threads:[~2013-12-14 19:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-14 19:23 David Cohen [this message]
2013-12-16 10:13 ` [PATCH] x86: intel-mid: make X86_INTEL_MID depending on SFI Ingo Molnar
2013-12-16 18:07   ` David Cohen
2013-12-16 19:31     ` David Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387049004-21622-1-git-send-email-david.a.cohen@linux.intel.com \
    --to=david.a.cohen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox