From: Mark Salter <msalter@redhat.com>
To: Dave Young <dyoung@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Leif Lindholm <leif.lindholm@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@kernel.org>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/4] Create generic early_ioremap() support
Date: Tue, 17 Dec 2013 13:45:38 -0500 [thread overview]
Message-ID: <1387305938.1979.166.camel@deneb.redhat.com> (raw)
In-Reply-To: <20131216014813.GA5631@dhcp-16-126.nay.redhat.com>
On Mon, 2013-12-16 at 09:48 +0800, Dave Young wrote:
> On 11/27/13 at 09:44pm, Mark Salter wrote:
> > This patch copies generic bits of x86 early_ioremap() support
> > into a library for potential use by other architectures.
> >
> > Signed-off-by: Mark Salter <msalter@redhat.com>
> > CC: Arnd Bergmann <arnd@arndb.de>
> > CC: Ingo Molnar <mingo@kernel.org>
> > CC: linux-arch@vger.kernel.org
> > ---
> > include/asm-generic/early_ioremap.h | 40 ++++++
> > lib/Kconfig | 3 +
> > lib/Makefile | 1 +
> > lib/early_ioremap.c | 243
> ++++++++++++++++++++++++++++++++++++
>
> I do not understand why these should go to lib/, I feel it's slightly better
> move them to mm/
>
> ditto about lib/ioremap.c, ...
>
I hadn't really thought about it. Putting these things in mm doesn't
sound unreasonable, but lib seems to have become the place for a lot
generic code which could also belong in mm, net, etc.
next prev parent reply other threads:[~2013-12-17 18:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 2:44 [PATCH 0/4] generic early_ioremap support Mark Salter
2013-11-28 2:44 ` [PATCH 1/4] Create generic early_ioremap() support Mark Salter
2013-12-16 1:48 ` Dave Young
2013-12-17 18:45 ` Mark Salter [this message]
2013-12-18 9:13 ` Dave Young
2013-12-18 10:40 ` Arnd Bergmann
2013-11-28 2:44 ` [PATCH 2/4] x86: use generic early_ioremap Mark Salter
2013-11-28 2:44 ` [PATCH 3/4] arm: add early_ioremap support Mark Salter
2013-11-28 2:44 ` [PATCH 4/4] arm64: " Mark Salter
2013-12-05 16:28 ` Catalin Marinas
2013-12-06 17:20 ` Mark Salter
2013-12-16 14:42 ` Catalin Marinas
2013-12-17 19:15 ` Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387305938.1979.166.camel@deneb.redhat.com \
--to=msalter@redhat.com \
--cc=arnd@arndb.de \
--cc=dyoung@redhat.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox