From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Francois Bedard <Francois.Bedard@synopsys.com>,
David Howells <dhowells@redhat.com>,
"Chen Gang" <gang.chen.5i5j@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>
Subject: [PATCH] Revert "ARC: Add guard macro to uapi/asm/unistd.h"
Date: Thu, 19 Dec 2013 16:43:18 +0530 [thread overview]
Message-ID: <1387451598-14490-1-git-send-email-vgupta@synopsys.com> (raw)
This reverts commit 97bc386fc12deeb41d5bff33548e3002b258d4e0.
Generic syscall table generator relies on ARCH unistd.h as follows:
void *sys_call_table[NR_syscalls] = {
[0 ... NR_syscalls-1] = sys_ni_syscall,
#include <asm/unistd.h>
};
And turns out that prior dependencies already include that header by
the time preprocessor hits the above. Meaning ARCH unistd.h needs to be
able to included twice.
This however means that perf cross comilation warning will re-appear
which needs to be discussed with perf folks (why they need to include
both libc variant as well as kernel internal header directly).
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
arch/arc/include/uapi/asm/unistd.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arc/include/uapi/asm/unistd.h b/arch/arc/include/uapi/asm/unistd.h
index 68125dd766c6..6f30484f34b7 100644
--- a/arch/arc/include/uapi/asm/unistd.h
+++ b/arch/arc/include/uapi/asm/unistd.h
@@ -8,9 +8,6 @@
/******** no-legacy-syscalls-ABI *******/
-#ifndef _UAPI_ASM_ARC_UNISTD_H
-#define _UAPI_ASM_ARC_UNISTD_H
-
#define __ARCH_WANT_SYS_EXECVE
#define __ARCH_WANT_SYS_CLONE
#define __ARCH_WANT_SYS_VFORK
@@ -35,5 +32,3 @@ __SYSCALL(__NR_arc_gettls, sys_arc_gettls)
/* Generic syscall (fs/filesystems.c - lost in asm-generic/unistd.h */
#define __NR_sysfs (__NR_arch_specific_syscall + 3)
__SYSCALL(__NR_sysfs, sys_sysfs)
-
-#endif
--
1.8.1.2
next reply other threads:[~2013-12-19 11:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 11:13 Vineet Gupta [this message]
2013-12-19 12:34 ` [PATCH] Revert "ARC: Add guard macro to uapi/asm/unistd.h" Chen Gang
2013-12-19 12:42 ` Geert Uytterhoeven
2013-12-19 13:41 ` Chen Gang
2013-12-19 13:11 ` Vineet Gupta
2013-12-19 13:42 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387451598-14490-1-git-send-email-vgupta@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox