* [PATCH] regulator: as3722: Don't set min_uV/uV_step/linear_min_sel for linear_ranges
@ 2013-12-20 2:57 Axel Lin
2013-12-20 8:33 ` Laxman Dewangan
2013-12-20 18:31 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-12-20 2:57 UTC (permalink / raw)
To: Mark Brown; +Cc: Laxman Dewangan, Liam Girdwood, linux-kernel
These settings are not used when using linear_ranges and it makes the code
looks confusing. Thus remove them.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/as3722-regulator.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/regulator/as3722-regulator.c b/drivers/regulator/as3722-regulator.c
index b9f1d24..27fe63c 100644
--- a/drivers/regulator/as3722-regulator.c
+++ b/drivers/regulator/as3722-regulator.c
@@ -842,9 +842,6 @@ static int as3722_regulator_probe(struct platform_device *pdev)
ops = &as3722_ldo_extcntrl_ops;
else
ops = &as3722_ldo_ops;
- as3722_regs->desc[id].min_uV = 825000;
- as3722_regs->desc[id].uV_step = 25000;
- as3722_regs->desc[id].linear_min_sel = 1;
as3722_regs->desc[id].enable_time = 500;
as3722_regs->desc[id].linear_ranges = as3722_ldo_ranges;
as3722_regs->desc[id].n_linear_ranges =
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: as3722: Don't set min_uV/uV_step/linear_min_sel for linear_ranges
2013-12-20 2:57 [PATCH] regulator: as3722: Don't set min_uV/uV_step/linear_min_sel for linear_ranges Axel Lin
@ 2013-12-20 8:33 ` Laxman Dewangan
2013-12-20 18:31 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Laxman Dewangan @ 2013-12-20 8:33 UTC (permalink / raw)
To: Axel Lin, Mark Brown; +Cc: Liam Girdwood, linux-kernel@vger.kernel.org
On Friday 20 December 2013 08:27 AM, Axel Lin wrote:
> These settings are not used when using linear_ranges and it makes the code
> looks confusing. Thus remove them.
Looks fine.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: as3722: Don't set min_uV/uV_step/linear_min_sel for linear_ranges
2013-12-20 2:57 [PATCH] regulator: as3722: Don't set min_uV/uV_step/linear_min_sel for linear_ranges Axel Lin
2013-12-20 8:33 ` Laxman Dewangan
@ 2013-12-20 18:31 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-12-20 18:31 UTC (permalink / raw)
To: Axel Lin; +Cc: Laxman Dewangan, Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
On Fri, Dec 20, 2013 at 10:57:49AM +0800, Axel Lin wrote:
> These settings are not used when using linear_ranges and it makes the code
> looks confusing. Thus remove them.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-20 18:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-20 2:57 [PATCH] regulator: as3722: Don't set min_uV/uV_step/linear_min_sel for linear_ranges Axel Lin
2013-12-20 8:33 ` Laxman Dewangan
2013-12-20 18:31 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox