Re: [PATCH v7 00/12] kexec kernel efi runtime support

Matt Fleming
2014-01-02T10:36:13Z

On Thu, 02 Jan, at 10:42:56AM, Dave Young wrote:
>
> Hi, Matt
>
> randconfig build robot reports several problems:
> 1. sparse warnings which should be fixed by the early_memremap patches

Yeah, this will be fixed up when Mark's memremap patch series gets
merged.

> Here is the fix for 2. and 3, please take a look. I'm not sure if I
> should resend the patches or leave them to you.

Please send these as separate patches and include the compiler errors in
the commit message. I'll pick them up and send them to Peter.

> build fix: move parse_efi_setup to efi*.c, call it in efi_init instead in setup.c

Why have you moved the call site for parse_efi_setup()? What's the
rationale? Parsing SETUP_* entries outside of parse_setup_data() seems
to me to be a step backwards in terms of clarity.

--
Matt Fleming, Intel Open Source Technology Center