From: Fabio Estevam <festevam@gmail.com>
To: broonie@kernel.org
Cc: shawn.guo@linaro.org, Anson.Huang@freescale.com,
linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: [PATCH v2 1/2] regulator: anatop-regulator: Only jump to 'anatop_probe_end' on error
Date: Sat, 21 Dec 2013 17:27:25 -0200 [thread overview]
Message-ID: <1387654046-30997-1-git-send-email-festevam@gmail.com> (raw)
From: Fabio Estevam <fabio.estevam@freescale.com>
Currently 'anatop_probe_end' path is executed on both succesfull and error paths
of anatop_regulator_probe().
To let the code a bit clearer, make 'anatop_probe_end' to be executed only when
an error happens.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/regulator/anatop-regulator.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/anatop-regulator.c b/drivers/regulator/anatop-regulator.c
index c734d09..53e6048 100644
--- a/drivers/regulator/anatop-regulator.c
+++ b/drivers/regulator/anatop-regulator.c
@@ -210,9 +210,10 @@ static int anatop_regulator_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, rdev);
+ return 0;
+
anatop_probe_end:
- if (ret)
- kfree(sreg->name);
+ kfree(sreg->name);
return ret;
}
--
1.8.1.2
next reply other threads:[~2013-12-21 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-21 19:27 Fabio Estevam [this message]
2013-12-21 19:27 ` [PATCH v2 2/2] regulator: anatop-regulator: Remove unneeded variable Fabio Estevam
2013-12-23 8:24 ` [PATCH v2 1/2] regulator: anatop-regulator: Only jump to 'anatop_probe_end' on error Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387654046-30997-1-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=Anson.Huang@freescale.com \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox