From: Ben Hutchings <bhutchings@solarflare.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: <linux-sctp@vger.kernel.org>, Vlad Yasevich <vyasevich@gmail.com>,
"David Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] sctp: Consolidate and ratelimit deprecation warnings
Date: Mon, 23 Dec 2013 22:55:16 +0000 [thread overview]
Message-ID: <1387839316.1635.8.camel@bwh-desktop.uk.level5networks.com> (raw)
In-Reply-To: <1387805383-21500-1-git-send-email-nhorman@tuxdriver.com>
On Mon, 2013-12-23 at 08:29 -0500, Neil Horman wrote:
> The SCTP protocol has several deprecation warnings in its setsockopt path that
> can be triggered by unprivlidged users. Since these are not ratelimited, we can
> spam the logs quite easily here. Since these are all deprecation warnings, and
> that type of warning isn't uncommon in the rest of the kernel, lets make a
> common pr_warn_deprecated macro to produce somewhat generalized ratelimited
> deprecation warnings easily
[...]
No objection to these changes, but I think deprecation warnings should
log at least the command name and maybe also the pid of the caller.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-12-23 22:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1387205049-22752-1-git-send-email-nhorman@tuxdriver.com>
2013-12-16 17:06 ` [PATCH v2 0/2] sctp: Consolidate and ratelimit deprecation warnings Neil Horman
2013-12-16 17:06 ` [PATCH v2 1/2] printk: Add a pr_warn_deprecated macro Neil Horman
2013-12-16 17:50 ` Joe Perches
2013-12-17 14:18 ` Neil Horman
2013-12-17 16:19 ` [PATCH v3 0/2] sctp: Consolidate and ratelimit deprecation warnings Neil Horman
2013-12-17 16:19 ` [PATCH v3 1/2] printk: Add a DEPRECATED macro Neil Horman
2013-12-22 22:56 ` [PATCH v3 0/2] sctp: Consolidate and ratelimit deprecation warnings David Miller
2013-12-23 13:19 ` Neil Horman
2013-12-23 13:29 ` [PATCH v4 " Neil Horman
2013-12-23 13:29 ` [PATCH v4 1/2] printk: Add a DEPRECATED macro Neil Horman
2013-12-23 22:55 ` Ben Hutchings [this message]
2013-12-24 13:37 ` [PATCH v4 0/2] sctp: Consolidate and ratelimit deprecation warnings Neil Horman
2013-12-31 19:00 ` David Miller
2013-12-31 20:08 ` Joe Perches
2014-01-02 14:31 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387839316.1635.8.camel@bwh-desktop.uk.level5networks.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).