From: Axel Lin <axel.lin@ingics.com>
To: Mark Brown <broonie@kernel.org>
Cc: Wenyou Yang <wenyou.yang@atmel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] regulator: act8865: Rmove unneeded regulator_unregister() calls
Date: Tue, 24 Dec 2013 23:41:22 +0800 [thread overview]
Message-ID: <1387899682.11622.1.camel@phoenix> (raw)
This is not required because current code use devm_regulator_register() to
register regulators.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/act8865-regulator.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c
index db048f2..dfae294 100644
--- a/drivers/regulator/act8865-regulator.c
+++ b/drivers/regulator/act8865-regulator.c
@@ -334,17 +334,6 @@ static int act8865_pmic_probe(struct i2c_client *client,
return 0;
}
-static int act8865_pmic_remove(struct i2c_client *client)
-{
- struct act8865 *act8865 = i2c_get_clientdata(client);
- int i;
-
- for (i = 0; i < ACT8865_REG_NUM; i++)
- regulator_unregister(act8865->rdev[i]);
-
- return 0;
-}
-
static const struct i2c_device_id act8865_ids[] = {
{ "act8865", 0 },
{ },
@@ -357,7 +346,6 @@ static struct i2c_driver act8865_pmic_driver = {
.owner = THIS_MODULE,
},
.probe = act8865_pmic_probe,
- .remove = act8865_pmic_remove,
.id_table = act8865_ids,
};
--
1.8.1.2
next reply other threads:[~2013-12-24 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 15:41 Axel Lin [this message]
2013-12-30 11:59 ` [PATCH] regulator: act8865: Rmove unneeded regulator_unregister() calls Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387899682.11622.1.camel@phoenix \
--to=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox