Re: [PATCH AUTOSEL 5.9 054/111] USB: cdc-acm: handle broken union descriptors

Greg Kroah-Hartman
2020-10-19T07:12:31Z

On Mon, Oct 19, 2020 at 09:02:18AM +0200, Johan Hovold wrote:
> On Sun, Oct 18, 2020 at 03:17:10PM -0400, Sasha Levin wrote:
> > From: Johan Hovold <johan@kernel.org>
> >
> > [ Upstream commit 960c7339de27c6d6fec13b54880501c3576bb08d ]
> >
> > Handle broken union functional descriptors where the master-interface
> > doesn't exist or where its class is of neither Communication or Data
> > type (as required by the specification) by falling back to
> > "combined-interface" probing.
> >
> > Note that this still allows for handling union descriptors with switched
> > interfaces.
> >
> > This specifically makes the Whistler radio scanners TRX series devices
> > work with the driver without adding further quirks to the device-id
> > table.
> >
> > Reported-by: Daniel Caujolle-Bert <f1rmb.daniel@gmail.com>
> > Tested-by: Daniel Caujolle-Bert <f1rmb.daniel@gmail.com>
> > Acked-by: Oliver Neukum <oneukum@suse.com>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > Link: https://lore.kernel.org/r/20200921135951.24045-3-johan@kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
>
> I was surprised to see this picked up by AUTOSEL since I remember adding
> a stable tag to this patch (to v2, changed my mind since v1) -- and it's
> there in the lore link above.
>
> Greg, just to make sure this wasn't due to a b4 bug; did you drop the
> stable tag on purpose when applying?

I did not, looks like b4 stripped it off!

> The tag-order has been reshuffled by b4 too it seems (I know, some
> people think that's ok) so maybe it fell out in the process.

I think so, let me verify it's a bug and report it to Konstantin...

thanks,

greg k-h