From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750861Ab3L1Txf (ORCPT ); Sat, 28 Dec 2013 14:53:35 -0500 Received: from smtprelay0026.hostedemail.com ([216.40.44.26]:59217 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750711Ab3L1Txe (ORCPT ); Sat, 28 Dec 2013 14:53:34 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3874:4250:4321:4605:5007:7652:7904:10004:10400:10848:11026:11232:11473:11658:11914:12296:12517:12519:12740:13069:13311:13357,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: crack00_3bfd931d8e82e X-Filterd-Recvd-Size: 2122 Message-ID: <1388260405.24123.18.camel@joe-AO722> Subject: Re: [PATCH] lib/vsprintf: add %pT[C012] format specifier From: Joe Perches To: Geert Uytterhoeven Cc: Andrew Morton , Tetsuo Handa , Jiri Kosina , Al Viro , "David S. Miller" , "linux-kernel@vger.kernel.org" Date: Sat, 28 Dec 2013 11:53:25 -0800 In-Reply-To: References: <201312252137.IDC43215.OLtJQFHOFMVFSO@I-love.SAKURA.ne.jp> <20131227150211.61328c02d61722cb212649e9@linux-foundation.org> <201312281243.CCB82366.tMHFVQFSOOFJOL@I-love.SAKURA.ne.jp> <20131228112509.8a62548c.akpm@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.8.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2013-12-28 at 20:25 +0100, Geert Uytterhoeven wrote: > On Sat, Dec 28, 2013 at 8:25 PM, Andrew Morton > wrote: > >> Is any of the "\x" (backslash + character) unused and thus available? > > > > I guess control characters would work. > > > > #define PRINTK_COMM "\001" > > Not that one, cfr. include/linux/kern_levels.h ;-) yup. > > #define PRINTK_PID "\002" > > #define PRINTK_TASK_ID "\003" /* "comm:pid" */ > > > > printk(PRINTK_TASK_ID ": hair on fire\n"); > > > > It's certainly compact. I doubt if there's any existing code which > > deliberately prints control chars? > > But the rest looks OK to me. Tell me again, what's wrong with using p or current? printk("%pt", current);