From: Ramkumar Ramachandra <artagnon@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH v6 1/4] perf tools: generalize percent_color_snprintf()
Date: Mon, 30 Dec 2013 13:04:18 +0530 [thread overview]
Message-ID: <1388388861-7931-2-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1388388861-7931-1-git-send-email-artagnon@gmail.com>
Make percent_color_snprintf() handle negative values correctly.
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
tools/perf/util/color.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/color.c b/tools/perf/util/color.c
index 66e44a5..8cda46c 100644
--- a/tools/perf/util/color.c
+++ b/tools/perf/util/color.c
@@ -1,6 +1,7 @@
#include <linux/kernel.h>
#include "cache.h"
#include "color.h"
+#include <math.h>
int perf_use_color_default = -1;
@@ -298,10 +299,10 @@ const char *get_percent_color(double percent)
* entries in green - and keep the low overhead places
* normal:
*/
- if (percent >= MIN_RED)
+ if (fabs(percent) >= MIN_RED)
color = PERF_COLOR_RED;
else {
- if (percent > MIN_GREEN)
+ if (fabs(percent) > MIN_GREEN)
color = PERF_COLOR_GREEN;
}
return color;
--
1.8.5.2.227.g53f3478
next prev parent reply other threads:[~2013-12-30 7:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 7:34 [PATCH v6 0/4] More color in 'perf diff' Ramkumar Ramachandra
2013-12-30 7:34 ` Ramkumar Ramachandra [this message]
2014-01-14 16:41 ` [tip:perf/core] perf tools: Generalize percent_color_snprintf() tip-bot for Ramkumar Ramachandra
2013-12-30 7:34 ` [PATCH v6 2/4] perf diff: color the Delta column Ramkumar Ramachandra
2014-01-14 16:41 ` [tip:perf/core] perf diff: Color " tip-bot for Ramkumar Ramachandra
2013-12-30 7:34 ` [PATCH v6 3/4] perf diff: color the Ratio column Ramkumar Ramachandra
2014-01-14 16:42 ` [tip:perf/core] perf diff: Color " tip-bot for Ramkumar Ramachandra
2013-12-30 7:34 ` [PATCH v6 4/4] perf diff: color the Weighted Diff column Ramkumar Ramachandra
2013-12-30 7:48 ` Ramkumar Ramachandra
2013-12-30 8:02 ` [PATCH v7] " Ramkumar Ramachandra
2014-01-14 16:42 ` [tip:perf/core] perf diff: Color " tip-bot for Ramkumar Ramachandra
2014-01-06 8:36 ` [PATCH v6 0/4] More color in 'perf diff' Ramkumar Ramachandra
2014-01-06 14:34 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388388861-7931-2-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=acme@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox