Re: [PATCH v3] Staging: rtl8188eu: Fixed coding style issues

[Joe Perches <joe@perches.com>]

On Fri, 2014-01-03 at 00:22 +0100, Tim Jester-Pfadt wrote:
> Fixed indentation coding style issues on rtw_io.c
[]
> diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c
[]
> @@ -205,9 +205,9 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
>  
>  	_func_enter_;
>  	if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
> -	     RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> -		      ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> -		      adapter->bDriverStopped, adapter->bSurpriseRemoved));
> +		RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> +			 ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> +			 adapter->bDriverStopped, adapter->bSurpriseRemoved));

Be nice to remove the unnecessary parentheses on all of these too

		RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
			 "rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
			 adapter->bDriverStopped, adapter->bSurpriseRemoved);

etc...

A few other things too:

o The _func_enter_ uses are unnecessary and could/should
  be removed.  There's a standard function tracing capability.
o The RT_TRACE uses that embed a function name could/should use
  %s:, __func__
o The RT_TRACE macro doesn't add a terminating newline and these
  uses should have them.

		RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
			 "%s:bDriverStopped(%d) OR bSurpriseRemoved(%d)\n",
			 __func__, adapter->bDriverStopped, adapter->bSurpriseRemoved);