Re: [PATCH] powerpc: Fix alignment of secondary cpu spin vars

Benjamin Herrenschmidt
2014-01-09T01:36:57Z

On Wed, 2014-01-08 at 09:48 -0800, Olof Johansson wrote:

> > /* If it's a display, note it */
> > - memset(type, 0, sizeof(type));
> > - prom_getprop(stdout_node, "device_type", type, sizeof(type));
> > - if (strcmp(type, "display") == 0)
> > - prom_setprop(stdout_node, path, "linux,boot-display", NULL, 0);
> > + stdout_node = call_prom("instance-to-package", 1, 1, prom.stdout);
> > + if (stdout_node != PROM_ERROR) {
> > + val = cpu_to_be32(stdout_node);
> > + memset(type, 0, sizeof(type));
> > + prom_getprop(stdout_node, "device_type", type, sizeof(type));
> > + if (strcmp(type, "display") == 0)
> > + prom_setprop(stdout_node, path, "linux,boot-display", NU
>
> Line is cut off, this needs "NULL, 0);" at the end.

Right, copy/paste failure :-)

Thanks, I'll try to get that to Linus before he cuts .13, otherwise it
will be -stable.

Cheers,
Ben.