From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Arun Sharma <asharma@fb.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>,
Rodrigo Campos <rodrigo@sdfg.com.ar>
Subject: [PATCH 05/28] perf hists: Convert hist entry functions to use struct he_stat
Date: Wed, 8 Jan 2014 17:46:10 +0900 [thread overview]
Message-ID: <1389170793-21926-6-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1389170793-21926-1-git-send-email-namhyung@kernel.org>
hist_entry__add_cpumode_period() and hist_entry__decay() are dealing
with hist_entry's stat fields only. So make them use the struct
directly.
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Arun Sharma <asharma@fb.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/hist.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 266d9b238856..ca3b3b707983 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -174,21 +174,21 @@ void hists__output_recalc_col_len(struct hists *hists, int max_rows)
}
}
-static void hist_entry__add_cpumode_period(struct hist_entry *he,
- unsigned int cpumode, u64 period)
+static void he_stat__add_cpumode_period(struct he_stat *he_stat,
+ unsigned int cpumode, u64 period)
{
switch (cpumode) {
case PERF_RECORD_MISC_KERNEL:
- he->stat.period_sys += period;
+ he_stat->period_sys += period;
break;
case PERF_RECORD_MISC_USER:
- he->stat.period_us += period;
+ he_stat->period_us += period;
break;
case PERF_RECORD_MISC_GUEST_KERNEL:
- he->stat.period_guest_sys += period;
+ he_stat->period_guest_sys += period;
break;
case PERF_RECORD_MISC_GUEST_USER:
- he->stat.period_guest_us += period;
+ he_stat->period_guest_us += period;
break;
default:
break;
@@ -215,10 +215,10 @@ static void he_stat__add_stat(struct he_stat *dest, struct he_stat *src)
dest->weight += src->weight;
}
-static void hist_entry__decay(struct hist_entry *he)
+static void he_stat__decay(struct he_stat *he_stat)
{
- he->stat.period = (he->stat.period * 7) / 8;
- he->stat.nr_events = (he->stat.nr_events * 7) / 8;
+ he_stat->period = (he_stat->period * 7) / 8;
+ he_stat->nr_events = (he_stat->nr_events * 7) / 8;
/* XXX need decay for weight too? */
}
@@ -229,7 +229,7 @@ static bool hists__decay_entry(struct hists *hists, struct hist_entry *he)
if (prev_period == 0)
return true;
- hist_entry__decay(he);
+ he_stat__decay(&he->stat);
if (!he->filtered)
hists->stats.total_period -= prev_period - he->stat.period;
@@ -395,7 +395,7 @@ static struct hist_entry *add_hist_entry(struct hists *hists,
rb_link_node(&he->rb_node_in, parent, p);
rb_insert_color(&he->rb_node_in, hists->entries_in);
out:
- hist_entry__add_cpumode_period(he, al->cpumode, period);
+ he_stat__add_cpumode_period(&he->stat, al->cpumode, period);
return he;
}
--
1.7.11.7
next prev parent reply other threads:[~2014-01-08 8:52 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 8:46 [PATCHSET 00/28] perf tools: Add support to accumulate hist periods (v5) Namhyung Kim
2014-01-08 8:46 ` [PATCH 01/28] perf tools: Insert filtered entries to hists also Namhyung Kim
2014-01-08 12:41 ` Arnaldo Carvalho de Melo
2014-01-08 16:22 ` Jiri Olsa
2014-01-08 18:59 ` Arnaldo Carvalho de Melo
2014-01-09 12:57 ` Namhyung Kim
2014-01-09 14:37 ` Arnaldo Carvalho de Melo
2014-01-14 0:15 ` Namhyung Kim
2014-01-08 8:46 ` [PATCH 02/28] perf tools: Do not update total period of a hists when filtering Namhyung Kim
2014-01-08 8:46 ` [PATCH 03/28] perf tools: Remove symbol_conf.use_callchain check Namhyung Kim
2014-01-08 12:57 ` Arnaldo Carvalho de Melo
2014-01-09 13:16 ` Namhyung Kim
2014-01-08 8:46 ` [PATCH 04/28] perf tools: Introduce struct hist_entry_iter Namhyung Kim
2014-01-08 8:46 ` Namhyung Kim [this message]
2014-01-08 8:46 ` [PATCH 06/28] perf hists: Add support for accumulated stat of hist entry Namhyung Kim
2014-01-08 8:46 ` [PATCH 07/28] perf hists: Check if accumulated when adding a " Namhyung Kim
2014-01-08 8:46 ` [PATCH 08/28] perf hists: Accumulate hist entry stat based on the callchain Namhyung Kim
2014-01-08 8:46 ` [PATCH 09/28] perf tools: Update cpumode for each cumulative entry Namhyung Kim
2014-01-08 8:46 ` [PATCH 10/28] perf report: Cache cumulative callchains Namhyung Kim
2014-01-09 18:06 ` Jiri Olsa
2014-01-13 23:55 ` Namhyung Kim
2014-01-14 13:17 ` Jiri Olsa
2014-01-11 16:02 ` Jiri Olsa
2014-01-13 8:45 ` Namhyung Kim
2014-01-08 8:46 ` [PATCH 11/28] perf callchain: Add callchain_cursor_snapshot() Namhyung Kim
2014-01-08 8:46 ` [PATCH 12/28] perf tools: Save callchain info for each cumulative entry Namhyung Kim
2014-01-08 8:46 ` [PATCH 13/28] perf hists: Sort hist entries by accumulated period Namhyung Kim
2014-01-08 8:46 ` [PATCH 14/28] perf ui/hist: Add support to accumulated hist stat Namhyung Kim
2014-01-08 8:46 ` [PATCH 15/28] perf ui/browser: " Namhyung Kim
2014-01-08 8:46 ` [PATCH 16/28] perf ui/gtk: " Namhyung Kim
2014-01-08 8:46 ` [PATCH 17/28] perf tools: Apply percent-limit to cumulative percentage Namhyung Kim
2014-01-08 8:46 ` [PATCH 18/28] perf tools: Add more hpp helper functions Namhyung Kim
2014-01-08 8:46 ` [PATCH 19/28] perf report: Add --children option Namhyung Kim
2014-01-08 8:46 ` [PATCH 20/28] perf report: Add report.children config option Namhyung Kim
2014-01-08 8:46 ` [PATCH 21/28] perf tools: Factor out sample__resolve_callchain() Namhyung Kim
2014-01-08 8:46 ` [PATCH 22/28] perf tools: Factor out fill_callchain_info() Namhyung Kim
2014-01-08 8:46 ` [PATCH 23/28] perf tools: Factor out hist_entry_iter code Namhyung Kim
2014-01-11 16:24 ` Jiri Olsa
2014-01-13 8:49 ` Namhyung Kim
2014-01-08 8:46 ` [PATCH 24/28] perf tools: Add callback function to hist_entry_iter Namhyung Kim
2014-01-08 8:46 ` [PATCH 25/28] perf top: Convert " Namhyung Kim
2014-01-11 16:35 ` Jiri Olsa
2014-01-13 8:55 ` Namhyung Kim
2014-01-13 10:45 ` Namhyung Kim
2014-01-08 8:46 ` [PATCH 26/28] perf top: Add --children option Namhyung Kim
2014-01-08 8:46 ` [PATCH 27/28] perf top: Add top.children config option Namhyung Kim
2014-01-08 8:46 ` [PATCH 28/28] perf tools: Enable --children option by default Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389170793-21926-6-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=asharma@fb.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=rodrigo@sdfg.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox