Re: [PATCH 03/28] perf tools: Remove symbol_conf.use_callchain check

Arnaldo Carvalho de Melo
2014-01-08T12:58:05Z

Em Wed, Jan 08, 2014 at 05:46:08PM +0900, Namhyung Kim escreveu:
> The machine__resolve_callchain() is called only if symbol_conf.
> use_callchain is set so no need to check it again.

Not really it may be called with use_callchain not set, I'm checking if
the logic is needed (doesn't look like).

- Arnaldo

> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/util/machine.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> index a98538dc465a..4dcc89490858 100644
> --- a/tools/perf/util/machine.c
> +++ b/tools/perf/util/machine.c
> @@ -1313,8 +1313,6 @@ static int machine__resolve_callchain_sample(struct machine *machine,
> *root_al = al;
> callchain_cursor_reset(&callchain_cursor);
> }
> - if (!symbol_conf.use_callchain)
> - break;
> }
>
> err = callchain_cursor_append(&callchain_cursor,
> --
> 1.7.11.7