public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.de>
To: rogerable@realtek.com
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>, Chris Ball <cjb@laptop.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Maxim Levitsky <maximlevitsky@gmail.com>,
	Alex Dubov <oakad@yahoo.com>,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	driverdev-devel@linuxdriverproject.org, wei_wang@realsil.com.cn,
	micky_ching@realsil.com.cn
Subject: Re: [PATCH 2/3] mmc: Add realtek USB sdmmc host driver
Date: Fri, 10 Jan 2014 13:49:02 +0100	[thread overview]
Message-ID: <1389358142.6807.36.camel@linux-fkkt.site> (raw)
In-Reply-To: <1387792327-2511-3-git-send-email-rogerable@realtek.com>

On Mon, 2013-12-23 at 17:52 +0800, rogerable@realtek.com wrote:
> From: Roger Tseng <rogerable@realtek.com>
> 
> Realtek USB SD/MMC host driver provides mmc host support based on the Realtek
> USB card reader MFD driver.
> 
> Signed-off-by: Roger Tseng <rogerable@realtek.com>

> +#ifdef DEBUG

Dynamic debugging would be nice.

> +static void sd_print_debug_regs(struct rtsx_usb_sdmmc *host)
> +{
> +	struct rtsx_ucr *ucr = host->ucr;
> +	u8 val = 0;
> +
> +	rtsx_usb_ep0_read_register(ucr, SD_STAT1, &val);
> +	dev_dbg(sdmmc_dev(host), "SD_STAT1: 0x%x\n", val);
> +	rtsx_usb_ep0_read_register(ucr, SD_STAT2, &val);
> +	dev_dbg(sdmmc_dev(host), "SD_STAT2: 0x%x\n", val);
> +	rtsx_usb_ep0_read_register(ucr, SD_BUS_STAT, &val);
> +	dev_dbg(sdmmc_dev(host), "SD_BUS_STAT: 0x%x\n", val);
> +}
> +#else
> +#define sd_print_debug_regs(host)
> +#endif /* DEBUG */
> +


	Regards
		Oliver



  reply	other threads:[~2014-01-10 12:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-23  9:52 [PATCH 0/3] Add modules for realtek USB card reader rogerable
2013-12-23  9:52 ` [PATCH 1/3] mfd: Add realtek USB card reader driver rogerable
2014-01-02  9:47   ` Dan Carpenter
2014-01-08  7:56     ` Roger Tseng
2014-01-08 13:03       ` Dan Carpenter
2014-01-10 12:42   ` Oliver Neukum
2013-12-23  9:52 ` [PATCH 2/3] mmc: Add realtek USB sdmmc host driver rogerable
2014-01-10 12:49   ` Oliver Neukum [this message]
2013-12-23  9:52 ` [PATCH 3/3] memstick: Add realtek USB memstick " rogerable
  -- strict thread matches above, loose matches on Subject: below --
2014-01-14  7:47 [PATCH v2 0/3] Add modules for realtek USB card reader rogerable
2014-01-14  7:47 ` [PATCH 2/3] mmc: Add realtek USB sdmmc host driver rogerable

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389358142.6807.36.camel@linux-fkkt.site \
    --to=oneukum@suse.de \
    --cc=cjb@laptop.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    --cc=micky_ching@realsil.com.cn \
    --cc=oakad@yahoo.com \
    --cc=rogerable@realtek.com \
    --cc=sameo@linux.intel.com \
    --cc=wei_wang@realsil.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox