public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: Baoquan <bhe@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
	kexec@lists.infradead.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-kernel@vger.kernel.org, tangchen@cn.fujitsu.com,
	linux-acpi@vger.kernel.org, zhangyanfei@cn.fujitsu.com,
	dyoung@redhat.com
Subject: Re: kdump failed because of hotplug memory adding in kdump kernel
Date: Fri, 10 Jan 2014 08:56:17 -0700	[thread overview]
Message-ID: <1389369377.1792.160.camel@misato.fc.hp.com> (raw)
In-Reply-To: <20140110071124.GA6464@dhcp-16-105.nay.redhat.com>

On Fri, 2014-01-10 at 15:11 +0800, Baoquan wrote:
> On 01/09/14 at 02:56pm, Toshi Kani wrote:
 :
> > I am more curious to know how makedumpfile decides what memory ranges to
> > dump.  The 1st kernel may have performed memory hot-add / delete
> > operations before a crash, so it needs to know the valid physical
> > address range at the time of crash, and may not rely on the E820 map
> > from BIOS (which is stale).  Am I right to assume that makedumpfile gets
> > it from the page tables of the 1st kernel?
> 
> makedumpfile just do the dump, what memory ranges to dump is decided in
> 1st kernel by kexec-tools. In 1st kernel, if kexec-tools executed, it
> will find all System Ram memorys which exclude the reserved regions for
> kdump kernel, then build a logical elf file, each load segment is one of
> these System Ram memory regions, its addr and length is written into the
> program header.
> 
> Then makedumpfile just read this elf file, and read all of them and
> dump.
> 
> If after kexec-tools execution and before crash, a hotplug memory is
> removed, udev will check this and trigger a kdump restart, kexec-tools
> is executed again, System Ram region information are stored. The logical
> file header will be passed to 2nd kernel.

Oh, that's how it works.  Thanks for the explanation!  In case of
hot-delete, ideally, the elf file should be updated after a memory
region is put into off-line, but before it is ejected.  But it is
difficult/vulnerable to coordinate such sequence with user space.  So,
the current scheme sounds good to me.

Thanks,
-Toshi


  parent reply	other threads:[~2014-01-10 16:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08 15:26 kdump failed because of hotplug memory adding in kdump kernel Baoquan
2014-01-08 15:58 ` Vivek Goyal
2014-01-08 23:07   ` Rafael J. Wysocki
2014-01-09  0:11     ` Toshi Kani
2014-01-09 13:10       ` Rafael J. Wysocki
2014-01-09 14:53         ` Vivek Goyal
2014-01-09 16:15           ` Toshi Kani
2014-01-09 14:50       ` Vivek Goyal
2014-01-09 16:03         ` Toshi Kani
2014-01-09 16:24           ` Vivek Goyal
2014-01-09 17:24             ` Toshi Kani
2014-01-09 18:23               ` Vivek Goyal
2014-01-09 18:34                 ` Toshi Kani
2014-01-09 21:27                   ` Vivek Goyal
2014-01-09 21:56                     ` Toshi Kani
2014-01-10  7:11                       ` Baoquan
2014-01-10  8:06                         ` Yasuaki Ishimatsu
2014-01-10  9:14                           ` Baoquan
2014-01-10  9:35                             ` Yasuaki Ishimatsu
2014-01-10 10:27                               ` Baoquan
2014-01-10 15:19                             ` Toshi Kani
2014-01-10 15:56                         ` Toshi Kani [this message]
2014-01-10  1:40                   ` Rafael J. Wysocki
2014-01-09  3:22     ` Baoquan
2014-01-09 14:48     ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389369377.1792.160.camel@misato.fc.hp.com \
    --to=toshi.kani@hp.com \
    --cc=bhe@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tangchen@cn.fujitsu.com \
    --cc=vgoyal@redhat.com \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox