From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Kent Overstreet <kmo@daterainc.com>, Neil Brown <neilb@suse.de>
Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH -next 2/2] bcache: Use max_t() when comparing different types
Date: Wed, 15 Jan 2014 10:06:24 +0100 [thread overview]
Message-ID: <1389776784-30825-2-git-send-email-geert@linux-m68k.org> (raw)
In-Reply-To: <1389776784-30825-1-git-send-email-geert@linux-m68k.org>
drivers/md/bcache/btree.c: In function ‘insert_u64s_remaining’:
drivers/md/bcache/btree.c:1816: warning: comparison of distinct pointer types lacks a cast
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/md/bcache/btree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index 98cc0a810a36..c2ebc850d9a9 100644
--- a/drivers/md/bcache/btree.c
+++ b/drivers/md/bcache/btree.c
@@ -1813,7 +1813,7 @@ static size_t insert_u64s_remaining(struct btree *b)
if (b->keys.ops->is_extents)
ret -= KEY_MAX_U64S;
- return max(ret, 0L);
+ return max_t(ssize_t, ret, 0L);
}
static bool bch_btree_insert_keys(struct btree *b, struct btree_op *op,
--
1.7.9.5
next prev parent reply other threads:[~2014-01-15 10:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 9:06 [PATCH -next 1/2] bcache: Use %zi to format size_t Geert Uytterhoeven
2014-01-15 9:06 ` Geert Uytterhoeven [this message]
2014-01-15 11:06 ` [PATCH -next 2/2] bcache: Use max_t() when comparing different types Joe Perches
2014-02-03 13:47 ` Geert Uytterhoeven
2014-02-06 9:00 ` Geert Uytterhoeven
2014-02-06 9:06 ` Joe Perches
2014-02-06 20:38 ` Andrew Morton
2014-02-06 20:45 ` Geert Uytterhoeven
2014-02-06 20:50 ` Andrew Morton
2014-02-06 20:53 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389776784-30825-2-git-send-email-geert@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=kmo@daterainc.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).