From: David Fries <David@Fries.net>
To: linux-kernel@vger.kernel.org
Cc: Evgeniy Polyakov <zbr@ioremap.net>, GregKH <greg@kroah.com>
Subject: [PATCH 03/15] w1: Only wake up the search process if it is going to be searching
Date: Wed, 15 Jan 2014 22:29:14 -0600 [thread overview]
Message-ID: <1389846566-28862-4-git-send-email-David@Fries.net> (raw)
In-Reply-To: <1389846566-28862-1-git-send-email-David@Fries.net>
It's valid to set the search count to 0 to stop searching, so don't
wake up the search thread to not search.
Signed-off-by: David Fries <David@Fries.net>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
---
drivers/w1/w1.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 67b6d5f..92766a9 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -243,7 +243,9 @@ static ssize_t w1_master_attribute_store_search(struct device * dev,
mutex_lock(&md->mutex);
md->search_count = tmp;
mutex_unlock(&md->mutex);
- wake_up_process(md->thread);
+ /* Only wake if it is going to be searching. */
+ if (tmp)
+ wake_up_process(md->thread);
return count;
}
--
1.7.10.4
next prev parent reply other threads:[~2014-01-16 4:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 4:29 [PATCH 00/14] w1: async netlink, search, fixes, and improvements David Fries
2014-01-16 4:29 ` [PATCH 01/15] w1: fix w1_send_slave dropping a slave id David Fries
2014-01-16 4:29 ` [PATCH 02/15] w1: fixup search to support abort from netlink David Fries
2014-01-16 4:29 ` David Fries [this message]
2014-01-16 4:29 ` [PATCH 04/15] w1: increase w1_max_slave_count, allow write access David Fries
2014-01-16 4:29 ` [PATCH 05/15] w1: continue slave search where previous left off David Fries
2014-01-16 4:29 ` [PATCH 06/15] w1: new netlink commands, add/remove/list slaves David Fries
2014-01-16 4:29 ` [PATCH 07/15] w1: process w1 netlink commands in w1_process thread David Fries
2014-01-16 4:29 ` [PATCH 08/15] connector: add portid to unicast in addition to broadcasting David Fries
2014-01-16 4:29 ` [PATCH 09/15] w1: reply only to the requester portid David Fries
2014-01-16 4:29 ` [PATCH 10/15] w1: ds2490 reduce magic numbers David Fries
2014-01-16 4:29 ` [PATCH 11/15] w1: ds2490 USB setup fixes David Fries
2014-01-16 4:29 ` [PATCH 12/15] w1: ds2490 fix and enable hardware search David Fries
2014-01-16 4:29 ` [PATCH 13/15] w1: use family_data instead of rom in w1_slave David Fries
2014-01-16 4:29 ` [PATCH 14/15] w1: format for DocBook and fixes David Fries
2014-01-16 4:29 ` [PATCH 15/15] w1: hold bus_mutex in netlink and search David Fries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389846566-28862-4-git-send-email-David@Fries.net \
--to=david@fries.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox