From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Depeng Shao <quic_depengs@quicinc.com>,
rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
vladimir.zapolskiy@linaro.org
Cc: quic_eberman@quicinc.com, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com,
Yongsheng Li <quic_yon@quicinc.com>
Subject: Re: [PATCH 15/16] media: qcom: camss: Add CSID 780 support
Date: Wed, 11 Dec 2024 21:57:31 +0000 [thread overview]
Message-ID: <138cc2e5-6b31-49d9-b70e-400a3f3c3bfa@linaro.org> (raw)
In-Reply-To: <20241211140738.3835588-16-quic_depengs@quicinc.com>
On 11/12/2024 14:07, Depeng Shao wrote:
> +static int csid_configure_testgen_pattern(struct csid_device *csid, s32 val)
> +{
> + return 0;
> +}
Could we avoid this empty callback by checking csid->ctrl in csid.c ?
If so, please make that change.
If not, it's fine.
For either case.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2024-12-11 21:57 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 14:07 [PATCH v6 00/16] media: qcom: camss: Add sm8550 support Depeng Shao
2024-12-11 14:07 ` [PATCH 01/16] media: qcom: camss: csiphy-3ph: Fix trivial indentation fault in defines Depeng Shao
2024-12-11 14:07 ` [PATCH 02/16] media: qcom: camss: csiphy-3ph: Remove redundant PHY init sequence control loop Depeng Shao
2024-12-11 15:38 ` Bryan O'Donoghue
2024-12-12 9:31 ` Depeng Shao
2024-12-11 14:07 ` [PATCH 03/16] media: qcom: camss: csiphy-3ph: Rename struct Depeng Shao
2024-12-11 14:07 ` [PATCH 04/16] media: qcom: camss: csiphy: Add an init callback to CSI PHY devices Depeng Shao
2024-12-11 14:07 ` [PATCH 05/16] media: qcom: camss: csiphy-3ph: Move CSIPHY variables to data field inside csiphy struct Depeng Shao
2024-12-11 14:07 ` [PATCH 06/16] media: qcom: camss: csiphy-3ph: Use an offset variable to find common control regs Depeng Shao
2024-12-11 14:07 ` [PATCH 07/16] media: qcom: camss: csid: Move common code into csid core Depeng Shao
2024-12-11 14:07 ` [PATCH 08/16] media: qcom: camss: vfe: Move common code into vfe core Depeng Shao
2024-12-12 1:06 ` Vladimir Zapolskiy
2024-12-12 1:35 ` Bryan O'Donoghue
2024-12-12 7:57 ` Vladimir Zapolskiy
2024-12-23 11:55 ` Depeng Shao
2024-12-11 14:07 ` [PATCH 09/16] media: qcom: camss: Add callback API for RUP update and buf done Depeng Shao
2024-12-12 1:09 ` Vladimir Zapolskiy
2024-12-12 1:32 ` Bryan O'Donoghue
2024-12-12 7:42 ` Vladimir Zapolskiy
2024-12-12 9:41 ` Depeng Shao
2024-12-11 14:07 ` [PATCH 10/16] media: qcom: camss: Add default case in vfe_src_pad_code Depeng Shao
2024-12-11 14:07 ` [PATCH 11/16] media: qcom: camss: csid: Add v4l2 ctrl if TPG mode isn't disabled Depeng Shao
2024-12-11 15:44 ` Bryan O'Donoghue
2024-12-23 13:09 ` Depeng Shao
2024-12-11 21:55 ` Bryan O'Donoghue
2024-12-11 14:07 ` [PATCH 12/16] dt-bindings: media: camss: Add qcom,sm8550-camss binding Depeng Shao
2024-12-11 15:17 ` Bryan O'Donoghue
2024-12-12 13:39 ` Depeng Shao
2024-12-12 14:04 ` Bryan O'Donoghue
2024-12-11 14:07 ` [PATCH 13/16] media: qcom: camss: Add sm8550 compatible Depeng Shao
2024-12-11 14:07 ` [PATCH 14/16] media: qcom: camss: csiphy-3ph: Add Gen2 v2.1.2 two-phase MIPI CSI-2 DPHY support Depeng Shao
2024-12-11 21:51 ` Bryan O'Donoghue
2024-12-11 14:07 ` [PATCH 15/16] media: qcom: camss: Add CSID 780 support Depeng Shao
2024-12-11 21:57 ` Bryan O'Donoghue [this message]
2024-12-12 11:28 ` Depeng Shao
2024-12-12 12:41 ` Bryan O'Donoghue
2024-12-11 14:07 ` [PATCH 16/16] media: qcom: camss: Add support for VFE 780 Depeng Shao
2024-12-11 15:36 ` [PATCH v6 00/16] media: qcom: camss: Add sm8550 support Bryan O'Donoghue
2024-12-11 16:03 ` Bryan O'Donoghue
2024-12-12 11:06 ` Depeng Shao
-- strict thread matches above, loose matches on Subject: below --
2024-12-25 13:35 [PATCH v7 " Depeng Shao
2024-12-25 13:35 ` [PATCH 15/16] media: qcom: camss: Add CSID 780 support Depeng Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=138cc2e5-6b31-49d9-b70e-400a3f3c3bfa@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_depengs@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_yon@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox