From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756082AbaAVPhV (ORCPT ); Wed, 22 Jan 2014 10:37:21 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:26127 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755223AbaAVPhO (ORCPT ); Wed, 22 Jan 2014 10:37:14 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfec7f4-b7f796d000005a13-55-52dfe5a75382 Content-transfer-encoding: 8BIT Message-id: <1390405030.18340.11.camel@AMDC1943> Subject: Re: [PATCH RESEND] cpufreq: exynos: Fix build error of no type of module_init From: Krzysztof Kozlowski To: Viresh Kumar , Paul Gortmaker Cc: "Rafael J. Wysocki" , Kukjin Kim , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , Linux Kernel Mailing List , Lukasz Majewski , Tomasz Figa , Kyungmin Park Date: Wed, 22 Jan 2014 16:37:10 +0100 In-reply-to: <1390402760.18340.6.camel@AMDC1943> References: <1390400476-22951-1-git-send-email-k.kozlowski@samsung.com> <1390402760.18340.6.camel@AMDC1943> X-Mailer: Evolution 3.2.3-0ubuntu6 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsVy+t/xq7rLn94PMuh6rW/xtOkHu0Xvgqts Fmeb3rBbvHm4mdFi0+NrrBaXd81hs/jce4TRYsb5fUwW1/YeZ7Y4c/oSq8X6Ga9ZLDZ+9XDg 8bhzbQ+bx+Yl9R5brrazePRtWcXo8XmTnMf6LVuZAtiiuGxSUnMyy1KL9O0SuDKaXn9hL9is WLHoZjtTA+NcmS5GTg4JAROJG82H2SFsMYkL99azdTFycQgJLGWUWLXzMCtIgldAUOLH5Hss XYwcHMwC8hJHLmWDhJkF1CUmzVvEDFH/mVGivecCE0S9gcSaP+fBeoUFIiQ6Lq1hAbHZBIwl Ni9fwgZiiwhESyyZeYMdpJlZoIlF4s272WBFLAKqEudW3mcEsTmBBn088JMdYsMWRok3CzsY IU5Vktjd3sk+gVFgFpIDZyEcOAvJgQsYmVcxiqaWJhcUJ6XnGuoVJ+YWl+al6yXn525ihMTH lx2Mi49ZHWIU4GBU4uEN3HUvSIg1say4MvcQowQHs5II75kH94OEeFMSK6tSi/Lji0pzUosP MTJxcEo1MFZ//PVxe1qw/IGvHpbHIiZXmPucKJnze3PprY+JV6bYnn0/xS4yLvJSRsiVsx/L n+i96leJm+43i2m9gmLYuk8Rr17l9RboxnbOuvRP67LqZPH+nHwbzuRpj7w/WpcmdqRzf2mW TbzwdaZQnFv9QtNv+zsfuZ765rp1a/iEOblbYrOmlzteK1NiKc5INNRiLipOBAAi9alibQIA AA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On Wed, 2014-01-22 at 20:12 +0530, Viresh Kumar wrote: > > On 22 January 2014 19:51, Krzysztof Kozlowski wrote: > > > Add missing include to fix build error: > > > drivers/cpufreq/exynos-cpufreq.c:292:1: warning: data definition has no type or storage class [enabled by default] > > > drivers/cpufreq/exynos-cpufreq.c:292:1: error: type defaults to ‘int’ in declaration of ‘module_init’ [-Werror=implicit-int] > > > drivers/cpufreq/exynos-cpufreq.c:292:1: warning: parameter names (without types) in function declaration [enabled by default] > > > drivers/cpufreq/exynos-cpufreq.c:292:1: warning: data definition has no type or storage class [enabled by default] > > > drivers/cpufreq/exynos-cpufreq.c:292:1: error: type defaults to ‘int’ in declaration of ‘module_exit’ [-Werror=implicit-int] > > > drivers/cpufreq/exynos-cpufreq.c:292:1: warning: parameter names (without types) in function declaration [enabled by default] > > > drivers/cpufreq/exynos-cpufreq.c:292:1: warning: ‘exynos_cpufreq_platdrv_init’ defined but not used [-Wunused-function] > > > cc1: some warnings being treated as errors > > > make[2]: *** [drivers/cpufreq/exynos-cpufreq.o] Error 1 > > > make[1]: *** [drivers/cpufreq] Error 2 > > > > > > Build error happens on gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) > > > and was introduced by commit d568b6f71df1 (cpufreq: exynos: Convert > > > exynos-cpufreq to platform driver). > > > > > > Signed-off-by: Krzysztof Kozlowski > > > Cc: Lukasz Majewski > > > Cc: Tomasz Figa > > > Cc: Kyungmin Park > > > --- > > > drivers/cpufreq/exynos-cpufreq.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c > > > index fcd2914d081a..fa54c2b88dd7 100644 > > > --- a/drivers/cpufreq/exynos-cpufreq.c > > > +++ b/drivers/cpufreq/exynos-cpufreq.c > > > @@ -17,6 +17,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > > I am surprised how that patch went through then? And nothing was > > reported by kbuild for it.. > > Hi, > > A little more explanation from my side: the build error actually happens > only on next/master, not Linus' tree. > > Mentioned commit which changes the driver to platform driver is in > mainline since 3.12-rc2 so it seems this is not the cause of the build > error. I think I need to find first the real cause of this build error. > > Best regards, > Krzysztof After bisecting, the real commit for build error is: caa7dcde7c424cdc81698a6e4e48072eb67ec67e module: relocate module_init from init.h to module.h My patch seems valid although the reason in commit msg should be updated: ################ Add missing include to fix build error: drivers/cpufreq/exynos-cpufreq.c:292:1: warning: data definition has no type or storage class [enabled by default] drivers/cpufreq/exynos-cpufreq.c:292:1: error: type defaults to ‘int’ in declaration of ‘module_init’ [-Werror=implicit-int] drivers/cpufreq/exynos-cpufreq.c:292:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/cpufreq/exynos-cpufreq.c:292:1: warning: data definition has no type or storage class [enabled by default] drivers/cpufreq/exynos-cpufreq.c:292:1: error: type defaults to ‘int’ in declaration of ‘module_exit’ [-Werror=implicit-int] drivers/cpufreq/exynos-cpufreq.c:292:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/cpufreq/exynos-cpufreq.c:292:1: warning: ‘exynos_cpufreq_platdrv_init’ defined but not used [-Wunused-function] cc1: some warnings being treated as errors make[2]: *** [drivers/cpufreq/exynos-cpufreq.o] Error 1 make[1]: *** [drivers/cpufreq] Error 2 Build error happens on gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) and was introduced in next tree by commit caa7dcde7c42 (module: relocate module_init from init.h to module.h). ################