From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932297AbaAWASl (ORCPT ); Wed, 22 Jan 2014 19:18:41 -0500 Received: from lgeamrelo01.lge.com ([156.147.1.125]:64605 "EHLO LGEAMRELO01.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756063AbaAWAOS (ORCPT ); Wed, 22 Jan 2014 19:14:18 -0500 X-AuditID: 9c93017d-b7b51ae000000e33-5b-52e05ed1a885 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Paul Mackerras , Namhyung Kim , LKML , Arun Sharma , Jiri Olsa , Rodrigo Campos , Andi Kleen , Frederic Weisbecker Subject: [PATCH 09/21] perf hists: Sort hist entries by accumulated period Date: Thu, 23 Jan 2014 09:13:53 +0900 Message-Id: <1390436045-16830-10-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1390436045-16830-1-git-send-email-namhyung@kernel.org> References: <1390436045-16830-1-git-send-email-namhyung@kernel.org> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When callchain accumulation is requested, we need to sort the entries by accumulated period value. When accumulated periods of two entries are same (i.e. single path callchain) put the caller above since accumulation tends to put callers on higher position for obvious reason. Tested-by: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/util/hist.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index 765ac5953201..da4fbec3d0d8 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -1063,6 +1063,18 @@ static int hist_entry__sort_on_period(struct hist_entry *a, struct hist_entry *pair; u64 *periods_a, *periods_b; + if (symbol_conf.cumulate_callchain) { + /* + * Put caller above callee when they have equal period. + */ + if (a->stat_acc->period != b->stat_acc->period) + return a->stat_acc->period > b->stat_acc->period ? 1 : -1; + + if (a->callchain->max_depth != b->callchain->max_depth) + return a->callchain->max_depth < b->callchain->max_depth ? + 1 : -1; + } + ret = period_cmp(a->stat.period, b->stat.period); if (ret || !symbol_conf.event_group) return ret; -- 1.7.11.7