public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matt Wilson <msw@linux.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "Matt Rushton" <mrushton@amazon.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Ian Campbell" <Ian.Campbell@citrix.com>,
	"David Vrabel" <david.vrabel@citrix.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xen.org,
	"Anthony Liguori" <aliguori@amazon.com>,
	"Matt Wilson" <msw@amazon.com>
Subject: [PATCH] xen-blkback: fix memory leak when persistent grants are used
Date: Thu, 23 Jan 2014 11:28:46 -0800	[thread overview]
Message-ID: <1390505326-9368-1-git-send-email-msw@linux.com> (raw)

From: Matt Rushton <mrushton@amazon.com>

Currently shrink_free_pagepool() is called before the pages used for
persistent grants are released via free_persistent_gnts(). This
results in a memory leak when a VBD that uses persistent grants is
torn down.

Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>
Cc: David Vrabel <david.vrabel@citrix.com>
Cc: linux-kernel@vger.kernel.org
Cc: xen-devel@lists.xen.org
Cc: Anthony Liguori <aliguori@amazon.com>
Signed-off-by: Matt Rushton <mrushton@amazon.com>
Signed-off-by: Matt Wilson <msw@amazon.com>
---
 drivers/block/xen-blkback/blkback.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index 6620b73..30ef7b3 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -625,9 +625,6 @@ purge_gnt_list:
 			print_stats(blkif);
 	}
 
-	/* Since we are shutting down remove all pages from the buffer */
-	shrink_free_pagepool(blkif, 0 /* All */);
-
 	/* Free all persistent grant pages */
 	if (!RB_EMPTY_ROOT(&blkif->persistent_gnts))
 		free_persistent_gnts(blkif, &blkif->persistent_gnts,
@@ -636,6 +633,9 @@ purge_gnt_list:
 	BUG_ON(!RB_EMPTY_ROOT(&blkif->persistent_gnts));
 	blkif->persistent_gnt_c = 0;
 
+	/* Since we are shutting down remove all pages from the buffer */
+	shrink_free_pagepool(blkif, 0 /* All */);
+
 	if (log_stats)
 		print_stats(blkif);
 
-- 
1.7.9.5


             reply	other threads:[~2014-01-23 19:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 19:28 Matt Wilson [this message]
2014-01-24  9:21 ` [PATCH] xen-blkback: fix memory leak when persistent grants are used Ian Campbell
2014-01-24 15:36   ` [Xen-devel] " Ian Campbell
2014-01-25 21:07     ` Matt Wilson
2014-01-26 18:01       ` Konrad Rzeszutek Wilk
2014-01-27 10:08       ` Ian Campbell
2014-01-24 10:39 ` Roger Pau Monné
2014-01-24 13:12 ` [Xen-devel] " Egger, Christoph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390505326-9368-1-git-send-email-msw@linux.com \
    --to=msw@linux.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=aliguori@amazon.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mrushton@amazon.com \
    --cc=msw@amazon.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox