public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Long <dave.long@linaro.org>
To: linux-arm-kernel@lists.infradead.org,
	Russell King <linux@arm.linux.org.uk>
Cc: Rabin Vincent <rabin@rab.in>,
	"Jon Medhurst (Tixy)" <tixy@linaro.org>,
	Oleg Nesterov <oleg@redhat.com>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Ingo Molnar <mingo@redhat.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	<davem@davemloft.net>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v5 06/16] ARM: Disable jprobes test when built into thumb-mode kernel
Date: Thu, 23 Jan 2014 15:05:49 -0500	[thread overview]
Message-ID: <1390507559-4697-7-git-send-email-dave.long@linaro.org> (raw)
In-Reply-To: <1390507559-4697-1-git-send-email-dave.long@linaro.org>

From: "Jon Medhurst (Tixy)" <tixy@linaro.org>

For now the jprobes tests fail on ARM for when built into a kernel compiled
in thumb mode. They work fine for ARM kernels, and when built as a loadable
module.

Signed-off-by: "Jon Medhurst (Tixy)" <tixy@linaro.org>
Signed-off-by: David A. Long <dave.long@linaro.org>
---
 arch/arm/kernel/kprobes-test.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/kernel/kprobes-test.c b/arch/arm/kernel/kprobes-test.c
index 0cd63d0..65230b2 100644
--- a/arch/arm/kernel/kprobes-test.c
+++ b/arch/arm/kernel/kprobes-test.c
@@ -221,6 +221,7 @@ static int pre_handler_called;
 static int post_handler_called;
 static int jprobe_func_called;
 static int kretprobe_handler_called;
+static int tests_failed;
 
 #define FUNC_ARG1 0x12345678
 #define FUNC_ARG2 0xabcdef
@@ -457,6 +458,13 @@ static int run_api_tests(long (*func)(long, long))
 
 	pr_info("    jprobe\n");
 	ret = test_jprobe(func);
+#if defined(CONFIG_THUMB2_KERNEL) && !defined(MODULE)
+	if (ret == -EINVAL) {
+		pr_err("FAIL: Known longtime bug with jprobe on Thumb kernels");
+		tests_failed = ret;
+		ret = 0;
+	}
+#endif
 	if (ret < 0)
 		return ret;
 
@@ -1667,6 +1675,8 @@ static int __init run_all_tests(void)
 
 out:
 	if (ret == 0)
+		ret = tests_failed;
+	if (ret == 0)
 		pr_info("Finished kprobe tests OK\n");
 	else
 		pr_err("kprobe tests failed\n");
-- 
1.8.1.2


  parent reply	other threads:[~2014-01-23 20:09 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 20:05 [PATCH v5 00/16] uprobes: Add uprobes support for ARM David Long
2014-01-23 20:05 ` [PATCH v5 01/16] uprobes: allow ignoring of probe hits David Long
2014-01-23 20:05 ` [PATCH v5 02/16] ARM: move shared uprobe/kprobe definitions into new include file David Long
2014-01-23 20:05 ` [PATCH v5 03/16] ARM: Move generic arm instruction parsing code to new files for sharing between features David Long
2014-01-23 20:05 ` [PATCH v5 04/16] ARM: move generic thumb instruction parsing code to new files for use by other feature David Long
2014-01-23 20:05 ` [PATCH v5 05/16] ARM: use a function table for determining instruction interpreter action David Long
2014-02-03 14:24   ` Jon Medhurst (Tixy)
2014-02-04  2:06     ` David Long
2014-01-23 20:05 ` David Long [this message]
2014-01-23 20:05 ` [PATCH v5 07/16] ARM: Remove use of struct kprobe from generic probes code David Long
2014-02-03 14:57   ` Jon Medhurst (Tixy)
2014-02-04  2:07     ` David Long
2014-01-23 20:05 ` [PATCH v5 08/16] ARM: Use new opcode type in ARM kprobes/uprobes code David Long
2014-01-23 20:05 ` [PATCH v5 09/16] ARM: Make the kprobes condition_check symbol names more generic David Long
2014-01-23 20:05 ` [PATCH v5 10/16] ARM: Change more ARM kprobes symbol names to something more David Long
2014-01-23 20:05 ` [PATCH v5 11/16] ARM: Rename the shared kprobes/uprobe return value enum David Long
2014-01-23 20:05 ` [PATCH v5 12/16] ARM: Change the remaining shared kprobes/uprobes symbols to something generic David Long
2014-01-23 20:05 ` [PATCH v5 13/16] ARM: Add an emulate flag to the kprobes/uprobes instruction decode functions David Long
2014-01-23 20:05 ` [PATCH v5 14/16] ARM: Make arch_specific_insn a define for new arch_probes_insn structure David Long
2014-01-23 20:05 ` [PATCH v5 15/16] ARM: add uprobes support David Long
2014-02-03 16:36   ` Jon Medhurst (Tixy)
2014-02-03 20:37     ` Rabin Vincent
2014-01-23 20:05 ` [PATCH v5 16/16] ARM: Remove uprobes dependency on kprobes David Long
2014-02-03 15:45   ` Jon Medhurst (Tixy)
2014-02-04  2:15     ` David Long
2014-02-03 16:44 ` [PATCH v5 00/16] uprobes: Add uprobes support for ARM Jon Medhurst (Tixy)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390507559-4697-7-git-send-email-dave.long@linaro.org \
    --to=dave.long@linaro.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=ananth@in.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=davem@davemloft.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=paulus@samba.org \
    --cc=rabin@rab.in \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=tixy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox