Re: [PATCH v3 1/3] pinctrl: Rename Broadcom Capri pinctrl driver

Linus Walleij
2014-04-10T16:51:19Z

On Thu, Apr 10, 2014 at 6:49 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Apr 3, 2014 at 12:40 AM, Sherman Yin <syin@broadcom.com> wrote:
>
>> To be consistent with other Broadcom drivers, the Broadcom Capri pinctrl
>> driver and its related CONFIG option are renamed to bcm281xx.
>>
>> Devicetree compatible string and binding documentation use
>> "brcm,bcm11351-pinctrl" to match the machine binding here:
>> Documentation/devicetree/bindings/arm/bcm/bcm11351.txt
>>
>> This driver supports pinctrl on BCM11130, BCM11140, BCM11351, BCM28145
>> and BCM28155 SoCs.
>>
>> Signed-off-by: Sherman Yin <syin@broadcom.com>
>> Reviewed-by: Matt Porter <mporter@linaro.org>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> drivers/pinctrl/Kconfig | 8 +-
>> drivers/pinctrl/Makefile | 2 +-
>> .../{pinctrl-capri.c => pinctrl-bcm281xx.c} | 1519 ++++++++++----------
>
> This last version from apr 7 does not change
> arch/arm/configs/bcm_defconfig:CONFIG_PINCTRL_CAPRI=y
>
> Doesn't this mean that you render this platform without a pin
> control driver and thus broken?

Bah I see that it's a separate patch now, sorry...

Looking closer.

Yours,
Linus Walleij