From: Oleg Drokin <green@linuxhacker.ru>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Cc: Oleg Drokin <green@linuxhacker.ru>,
"Christopher J. Morrone" <morrone2@llnl.gov>,
Oleg Drokin <oleg.drokin@intel.com>
Subject: [PATCH 3/5] lustre: Account for changelog_ext_rec in CR_MAXSIZE
Date: Thu, 23 Jan 2014 23:45:06 -0500 [thread overview]
Message-ID: <1390538708-4120-4-git-send-email-green@linuxhacker.ru> (raw)
In-Reply-To: <1390538708-4120-1-git-send-email-green@linuxhacker.ru>
CR_MAXSIZE needs to account for an llog_changelog_rec that actually
contains a changelog_ext_rec structure rather than a changelog_rec.
With out doing so, a file size approaching the Linux kernel NAME_MAX
length that is renamed to a size also close to, or at, NAME_MAX will
exceed CR_MAXSIZE and trip an assertion.
Signed-off-by: Christopher J. Morrone <morrone2@llnl.gov>
Reviewed-on: http://review.whamcloud.com/6993
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3587
Reviewed-by: Niu Yawei <yawei.niu@intel.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
---
drivers/staging/lustre/lustre/include/lustre/lustre_user.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
index 6b6c0240..7893d83 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
@@ -760,7 +760,8 @@ static inline void hsm_set_cl_error(int *flags, int error)
*flags |= (error << CLF_HSM_ERR_L);
}
-#define CR_MAXSIZE cfs_size_round(2*NAME_MAX + 1 + sizeof(struct changelog_rec))
+#define CR_MAXSIZE cfs_size_round(2*NAME_MAX + 1 + \
+ sizeof(struct changelog_ext_rec))
struct changelog_rec {
__u16 cr_namelen;
--
1.8.5.3
next prev parent reply other threads:[~2014-01-24 5:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 4:45 [PATCH 0/5] Lustre fixes from my testing Oleg Drokin
2014-01-24 4:45 ` [PATCH 1/5] staging/lustre: fix compile warning with is_vmalloc_addr Oleg Drokin
2014-01-24 4:45 ` [PATCH 2/5] staging/lustre/lnet: Fix use after free in ksocknal_send Oleg Drokin
2014-01-24 4:45 ` Oleg Drokin [this message]
2014-01-24 4:45 ` [PATCH 4/5] lustre: Correct KUC code max changelog msg size Oleg Drokin
2014-01-24 4:45 ` [PATCH 5/5] lustre: add myself to list of people to CC on lustre patches Oleg Drokin
2014-01-24 5:44 ` Joe Perches
2014-01-24 5:51 ` Oleg Drokin
2014-01-24 8:55 ` Geert Uytterhoeven
2014-01-25 3:23 ` Oleg Drokin
2014-01-28 19:28 ` Geert Uytterhoeven
2014-01-29 13:02 ` Greg Kroah-Hartman
2014-03-26 8:44 ` Geert Uytterhoeven
2014-03-26 9:02 ` Christoph Hellwig
2014-03-26 16:10 ` Oleg Drokin
2014-01-24 8:12 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390538708-4120-4-git-send-email-green@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morrone2@llnl.gov \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox