public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	linux-kernel@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 2/3] x86: Revert wrong memblock current limit setting.
Date: Fri, 24 Jan 2014 11:11:08 -0800	[thread overview]
Message-ID: <1390590670-25901-2-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1390590670-25901-1-git-send-email-yinghai@kernel.org>

Dave reported big numa system booting is broken.

It turns out
| commit 5b6e529521d35e1bcaa0fe43456d1bbb335cae5d
| Author: Santosh Shilimkar <santosh.shilimkar@ti.com>
| Date:   Tue Jan 21 15:50:03 2014 -0800
|
|    x86: memblock: set current limit to max low memory address

set limit to low wrongly.

max_low_pfn_mapped is different from max_pfn_mapped.
max_low_pfn_mapped is always under 4G.

That will memblock_alloc_nid all go under 4G.

Revert that offending patch.

Reported-by: Dave Hansen <dave.hansen@intel.com>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 arch/x86/include/asm/page_types.h |    4 ++--
 arch/x86/kernel/setup.c           |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Index: linux-2.6/arch/x86/include/asm/page_types.h
===================================================================
--- linux-2.6.orig/arch/x86/include/asm/page_types.h
+++ linux-2.6/arch/x86/include/asm/page_types.h
@@ -51,9 +51,9 @@ extern int devmem_is_allowed(unsigned lo
 extern unsigned long max_low_pfn_mapped;
 extern unsigned long max_pfn_mapped;
 
-static inline phys_addr_t get_max_low_mapped(void)
+static inline phys_addr_t get_max_mapped(void)
 {
-	return (phys_addr_t)max_low_pfn_mapped << PAGE_SHIFT;
+	return (phys_addr_t)max_pfn_mapped << PAGE_SHIFT;
 }
 
 bool pfn_range_is_mapped(unsigned long start_pfn, unsigned long end_pfn);
Index: linux-2.6/arch/x86/kernel/setup.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/setup.c
+++ linux-2.6/arch/x86/kernel/setup.c
@@ -1173,7 +1173,7 @@ void __init setup_arch(char **cmdline_p)
 
 	setup_real_mode();
 
-	memblock_set_current_limit(get_max_low_mapped());
+	memblock_set_current_limit(get_max_mapped());
 	dma_contiguous_reserve(0);
 
 	/*

  reply	other threads:[~2014-01-24 19:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24 19:11 [PATCH 0/3] memblock, x86: fix big numa system booting Yinghai Lu
2014-01-24 19:11 ` Yinghai Lu [this message]
2014-01-24 19:11 ` [PATCH 3/3] memblock: Don't align size silent in memblock_virt_alloc() Yinghai Lu
2014-01-24 19:11 ` [PATCH 1/3] memblock, nobootmem: Add memblock_virt_alloc_low() Yinghai Lu
2014-01-24 19:25   ` Konrad Rzeszutek Wilk
2014-01-24 19:30     ` Santosh Shilimkar
2014-01-24 19:34     ` Yinghai Lu
2014-01-28  8:02   ` Olof Johansson
2014-01-28 15:30     ` Kevin Hilman
2014-01-28 17:12       ` Yinghai Lu
2014-01-28 17:18         ` Russell King - ARM Linux
2014-01-28 17:23           ` Santosh Shilimkar
2014-01-28 19:43           ` Yinghai Lu
2014-01-28 19:47             ` Russell King - ARM Linux
2014-01-28 19:55               ` Yinghai Lu
2014-01-28 20:17                 ` Yinghai Lu
2014-01-28 17:23         ` Santosh Shilimkar
2014-01-28 18:22           ` Russell King - ARM Linux
2014-01-28 18:36             ` Santosh Shilimkar
2014-01-28 18:56               ` Konrad Rzeszutek Wilk
2014-01-28 20:16                 ` Strashko, Grygorii
2014-01-28 20:17             ` Linus Torvalds
2014-01-28 20:20               ` Yinghai Lu
2014-01-24 19:33 ` [PATCH 0/3] memblock, x86: fix big numa system booting Santosh Shilimkar
2014-01-24 20:17   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390590670-25901-2-git-send-email-yinghai@kernel.org \
    --to=yinghai@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=santosh.shilimkar@ti.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox