From: Yinghai Lu <yinghai@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
linux-kernel@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 3/3] memblock: Don't align size silent in memblock_virt_alloc()
Date: Fri, 24 Jan 2014 11:11:09 -0800 [thread overview]
Message-ID: <1390590670-25901-3-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1390590670-25901-1-git-send-email-yinghai@kernel.org>
In original __alloc_memory_core_early() for bootmem wrapper, we do not
align size silently.
We should not do that, as later free with old size will leave some
range not freed.
It's obvious that code is copied from memblock_base_nid(), and that code
is wrong for the same reason.
Also remove that in memblock_alloc_base.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
mm/memblock.c | 6 ------
1 file changed, 6 deletions(-)
Index: linux-2.6/mm/memblock.c
===================================================================
--- linux-2.6.orig/mm/memblock.c
+++ linux-2.6/mm/memblock.c
@@ -981,9 +981,6 @@ static phys_addr_t __init memblock_alloc
if (!align)
align = SMP_CACHE_BYTES;
- /* align @size to avoid excessive fragmentation on reserved array */
- size = round_up(size, align);
-
found = memblock_find_in_range_node(size, align, 0, max_addr, nid);
if (found && !memblock_reserve(found, size))
return found;
@@ -1077,9 +1074,6 @@ static void * __init memblock_virt_alloc
if (!align)
align = SMP_CACHE_BYTES;
- /* align @size to avoid excessive fragmentation on reserved array */
- size = round_up(size, align);
-
again:
alloc = memblock_find_in_range_node(size, align, min_addr, max_addr,
nid);
next prev parent reply other threads:[~2014-01-24 19:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 19:11 [PATCH 0/3] memblock, x86: fix big numa system booting Yinghai Lu
2014-01-24 19:11 ` [PATCH 2/3] x86: Revert wrong memblock current limit setting Yinghai Lu
2014-01-24 19:11 ` Yinghai Lu [this message]
2014-01-24 19:11 ` [PATCH 1/3] memblock, nobootmem: Add memblock_virt_alloc_low() Yinghai Lu
2014-01-24 19:25 ` Konrad Rzeszutek Wilk
2014-01-24 19:30 ` Santosh Shilimkar
2014-01-24 19:34 ` Yinghai Lu
2014-01-28 8:02 ` Olof Johansson
2014-01-28 15:30 ` Kevin Hilman
2014-01-28 17:12 ` Yinghai Lu
2014-01-28 17:18 ` Russell King - ARM Linux
2014-01-28 17:23 ` Santosh Shilimkar
2014-01-28 19:43 ` Yinghai Lu
2014-01-28 19:47 ` Russell King - ARM Linux
2014-01-28 19:55 ` Yinghai Lu
2014-01-28 20:17 ` Yinghai Lu
2014-01-28 17:23 ` Santosh Shilimkar
2014-01-28 18:22 ` Russell King - ARM Linux
2014-01-28 18:36 ` Santosh Shilimkar
2014-01-28 18:56 ` Konrad Rzeszutek Wilk
2014-01-28 20:16 ` Strashko, Grygorii
2014-01-28 20:17 ` Linus Torvalds
2014-01-28 20:20 ` Yinghai Lu
2014-01-24 19:33 ` [PATCH 0/3] memblock, x86: fix big numa system booting Santosh Shilimkar
2014-01-24 20:17 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390590670-25901-3-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=santosh.shilimkar@ti.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox