public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: "Adrien Vergé" <adrienverge@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	"Nicolo'" <nicolopiazzalunga@gmail.com>,
	David Henningsson <david.henningsson@canonical.com>,
	Kailang Yang <kailang@realtek.com>,
	Hui Wang <hui.wang@canonical.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda - Fix silent output on MacBook Air 1,1
Date: Fri, 24 Jan 2014 21:14:44 +0100	[thread overview]
Message-ID: <1390594484.15637.2.camel@x220> (raw)
In-Reply-To: <1390593374-6592-1-git-send-email-adrienverge@gmail.com>

On Fri, 2014-01-24 at 14:56 -0500, Adrien Vergé wrote:
> Similarly to other Apple products, MBA 1,1 needs a specific quirk.
> Pin 0x18 must be set to VREF_50 to have sound output.  This was no
> longer done since commit 1a97b7f, resulting in a mute built-in speaker.

Commit 1a97b7f ("ALSA: hda/realtek - Remove the last static quirks for
ALC882") was included in v3.4. Did no-one notice this for 9 releases?

> This patch corrects the regression by creating a fixup for the MBA 1,1.
> 
> Tested-by: Adrien Vergé <adrienverge@gmail.com>
> Signed-off-by: Adrien Vergé <adrienverge@gmail.com>


Paul Bolle


  reply	other threads:[~2014-01-24 20:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24 19:56 [PATCH] ALSA: hda - Fix silent output on MacBook Air 1,1 Adrien Vergé
2014-01-24 20:14 ` Paul Bolle [this message]
2014-01-24 20:46   ` Adrien Vergé
2014-01-24 21:08     ` Paul Bolle
2014-01-25  8:18       ` Takashi Iwai
2014-01-25 10:17         ` Nicolo'
2014-01-25 14:36           ` Adrien Vergé
2014-01-25 14:47             ` Nicolo'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390594484.15637.2.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=adrienverge@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.henningsson@canonical.com \
    --cc=hui.wang@canonical.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolopiazzalunga@gmail.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox