From: Mike Galbraith <bitbucket@online.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>
Subject: Re: [PATCH RT 4/8] rtmutex: use a trylock for waiter lock in trylock
Date: Sat, 01 Feb 2014 05:21:35 +0100 [thread overview]
Message-ID: <1391228495.5348.82.camel@marge.simpson.net> (raw)
In-Reply-To: <20140131220737.GF21238@linutronix.de>
On Fri, 2014-01-31 at 23:07 +0100, Sebastian Andrzej Siewior wrote:
> * Mike Galbraith | 2014-01-17 06:17:12 [+0100]:
>
> >On Thu, 2014-01-16 at 23:22 -0500, Steven Rostedt wrote:
> >> On Thu, 16 Jan 2014 04:08:57 +0100
> >> Mike Galbraith <bitbucket@online.de> wrote:
> >>
> >> > On Wed, 2014-01-15 at 20:58 -0500, Steven Rostedt wrote:
> >> >
> >> >
> >> > > 3.2.53-rt76-rc1 stable review patch.
> >> > > If anyone has any objections, please let me know.
> >> >
> >> > Not sure this is needed without the tglx don't unconditionally raise
> >> > timer softirq patch, and with that patch applied in the form it exists
> >> > in 3.12-rt9, as well as this one, you'll still eventually deadlock.
> >>
> >> Hmm, I'll have to take a look. This sounds to be missing from all the
> >> stable -rt kernels. I'll be pulling in the latest updates from 3.12-rt
> >> soon.
> >
> >Below are the two deadlocks I encountered with 3.12-rt9, which has both
> >$subject and timers-do-not-raise-softirq-unconditionally.patch applied.
>
> This patch was introduced because we had a deadlock in
> run_local_timers() which took a sleeping lock in hardirq context. This
> seem not to be the case in v3.2 therefore I would suggest not to take
> this patch here because it does not fix anything.
>
> Mike, do you see these deadlocks with 3.12.*-rt11 as well?
No. I beat 64 core box hard configured both nohz_idle and nohz_full,
the only thing that fell out was the nohz_full irqs enabled warning.
If Stevens patch didn't fix them, it did make them hide very well.
-Mike
next prev parent reply other threads:[~2014-02-01 4:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 1:58 [PATCH RT 0/8] Linux 3.2.53-rt76-rc1 Steven Rostedt
2014-01-16 1:58 ` [PATCH RT 1/8] cpu_down: move migrate_enable() back Steven Rostedt
2014-01-16 1:58 ` [PATCH RT 2/8] swait: Add a few more users Steven Rostedt
2014-01-16 1:58 ` [PATCH RT 3/8] lockdep: Correctly annotate hardirq context in irq_exit() Steven Rostedt
2014-01-16 1:58 ` [PATCH RT 4/8] rtmutex: use a trylock for waiter lock in trylock Steven Rostedt
2014-01-16 3:08 ` Mike Galbraith
2014-01-17 4:22 ` Steven Rostedt
2014-01-17 5:17 ` Mike Galbraith
2014-01-31 22:07 ` Sebastian Andrzej Siewior
2014-02-01 4:21 ` Mike Galbraith [this message]
2014-02-01 4:54 ` Mike Galbraith
2014-01-16 1:58 ` [PATCH RT 5/8] smp: introduce a generic on_each_cpu_mask() function Steven Rostedt
2014-01-16 1:58 ` [PATCH RT 6/8] smp: add func to IPI cpus based on parameter func Steven Rostedt
2014-01-16 1:58 ` [PATCH RT 7/8] fs: only send IPI to invalidate LRU BH when needed Steven Rostedt
2014-01-16 1:58 ` [PATCH RT 8/8] Linux 3.2.53-rt76-rc1 Steven Rostedt
2014-01-16 9:41 ` [PATCH RT 0/8] " Pavel Vasilyev
2014-01-16 14:18 ` Steven Rostedt
2014-01-16 14:36 ` Pavel Vasilyev
2014-01-16 15:09 ` Steven Rostedt
2014-01-16 16:08 ` Steven Rostedt
2014-01-16 17:19 ` Pavel Vasilyev
2014-01-16 16:18 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391228495.5348.82.camel@marge.simpson.net \
--to=bitbucket@online.de \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox