Re: [PATCH 0/4] w1: refcnt fix, skip non-error send, docs

zbr
2014-02-04T23:59:01Z

Hi

04.02.2014, 09:51, "David Fries" <david@fries.net>:
> Help me understand what the protocol is supposed to be.  Assuming
> there aren't any errors, is there supposed to be a
> w1_netlink_send_error generated reply per netlink packet (cn_msg), per
> w1_netlink_msg, or per w1_netlink_cmd?

reply should be sent per cmd to specify each command status
If there is no cmd in request or we didn't get to it (like failed to reset device), we should send error.

Depending on how w1-msg + (optional) w1-cmd are packed, client can detect what exact error happend

> What about the cn_msg seq and ack values?  I assume the kernel
> response should carry the same seq number as the request, but what
> should the ack be set to?

reply ack is seq + 1
seq is the same to highlight request it belongs to