From: Hannes Reinecke <hare@suse.de>
To: systemd-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
Lennart Poettering <lennart@poettering.net>,
Kay Sievers <kay@vrfy.org>, Werner Fink <werner@suse.de>
Subject: [PATCH] tty: Set correct tty name in 'active' sysfs attribute
Date: Wed, 5 Feb 2014 11:11:46 +0100 [thread overview]
Message-ID: <1391595106-86957-1-git-send-email-hare@suse.de> (raw)
The 'active' sysfs attribute should refer to the currently
active tty devices the console is running on, not the currently
active console.
The console structure doesn't refer to any device in sysfs,
only the tty the console is running on has.
So we need to print out the tty names in 'active', not
the console names.
Cc: Lennart Poettering <lennart@poettering.net>
Cc: Kay Sievers <kay@vrfy.org>
Signed-off-by: Werner Fink <werner@suse.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/tty/tty_io.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index c74a00a..17db8ca 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -3545,9 +3545,19 @@ static ssize_t show_cons_active(struct device *dev,
if (i >= ARRAY_SIZE(cs))
break;
}
- while (i--)
+ while (i--) {
+ const struct tty_driver *driver;
+ const char *name = cs[i]->name;
+ int index = cs[i]->index;
+
+ driver = cs[i]->device(cs[i], &index);
+ if (driver) {
+ index += driver->name_base;
+ name = driver->name;
+ }
count += sprintf(buf + count, "%s%d%c",
- cs[i]->name, cs[i]->index, i ? ' ':'\n');
+ name, index, i ? ' ':'\n');
+ }
console_unlock();
return count;
--
1.7.12.4
next reply other threads:[~2014-02-05 10:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 10:11 Hannes Reinecke [this message]
2014-02-05 12:53 ` [systemd-devel] [PATCH] tty: Set correct tty name in 'active' sysfs attribute David Herrmann
2014-02-05 13:53 ` Peter Hurley
2014-02-05 14:05 ` David Herrmann
2014-02-05 14:19 ` Peter Hurley
2014-02-06 15:46 ` Hannes Reinecke
2014-02-05 16:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391595106-86957-1-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=kay@vrfy.org \
--cc=lennart@poettering.net \
--cc=linux-kernel@vger.kernel.org \
--cc=systemd-devel@lists.freedesktop.org \
--cc=werner@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox