Re: intel_sdvo_init: trying to register non-static key

Imre Deak
2014-02-07T15:32:39Z

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

On Fri, 2014-02-07 at 15:51 +0100, Daniel Vetter wrote:
> On Fri, Feb 07, 2014 at 12:28:09PM +0100, Borislav Petkov wrote:
> > On Fri, Feb 07, 2014 at 01:12:22PM +0200, Imre Deak wrote:
> > > On Fri, 2014-02-07 at 13:04 +0200, Jani Nikula wrote:
> > > > Imre, is this the same i2c_del_adapter issue you're looking at? Any
> > > > patches to try yet?
> > >
> > > It looks like the same issue yes. The following patch fixed it for me:
> > >
> > > http://patchwork.freedesktop.org/patch/18698/
> > >
> > > I'm working on an improved version of this, but the main thing - to
> > > remove the connector's sysfs entries before actually destroying the
> > > encoder and connector objects - will remain the same as in the above
> > > patch.
> >
> > You could shoot the final version my way so that I give it a run too.
>
> The final version will only change the code layout a bit, but not the
> logic. So a tested-by from you for v1 would be helpful anyway, to make
> really sure you've reported the same issue. If that's not the case then we
> need to dig deeper, so better not to waste a few days waiting for v2.

I just realized it's a different issue, since it's on the init path.
Also we set the drm device as the parent for the sdvo i2c adapter as
opposed to the dp i2c adapter where it's the connector device. So the
above patch won't help in Borislav's case. I'm looking into this issue
anyway.

--Imre

> -Daniel

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]