public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: akpm@linux-foundation.org
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 10/14] asmlinkage Make __stack_chk_failed and memcmp visible
Date: Sat,  8 Feb 2014 08:52:06 +0100	[thread overview]
Message-ID: <1391845930-28580-10-git-send-email-ak@linux.intel.com> (raw)
In-Reply-To: <1391845930-28580-1-git-send-email-ak@linux.intel.com>

In LTO symbols implicitely referenced by the compiler need
to be visible. Earlier these symbols were visible implicitely
from being exported, but we disabled implicit visibility fo
 EXPORTs when modules are disabled to improve code size. So
now these symbols have to be marked visible explicitely.

Do this for __stack_chk_fail (with stack protector)
and memcmp.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 kernel/panic.c | 2 +-
 lib/string.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index 6d63003..3eb0ffb 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -459,7 +459,7 @@ EXPORT_SYMBOL(warn_slowpath_null);
  * Called when gcc's -fstack-protector feature is used, and
  * gcc detects corruption of the on-stack canary value
  */
-void __stack_chk_fail(void)
+__visible void __stack_chk_fail(void)
 {
 	panic("stack-protector: Kernel stack is corrupted in: %p\n",
 		__builtin_return_address(0));
diff --git a/lib/string.c b/lib/string.c
index e5878de..9b1f906 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -648,7 +648,7 @@ EXPORT_SYMBOL(memmove);
  * @count: The size of the area.
  */
 #undef memcmp
-int memcmp(const void *cs, const void *ct, size_t count)
+__visible int memcmp(const void *cs, const void *ct, size_t count)
 {
 	const unsigned char *su1, *su2;
 	int res = 0;
-- 
1.8.5.2


  parent reply	other threads:[~2014-02-08  7:53 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-08  7:51 [PATCH 01/14] asmlinkage, kvm: Make kvm_rebooting visible Andi Kleen
2014-02-08  7:51 ` [PATCH 02/14] asmlinkage: Make __iowrite32_copy visible Andi Kleen
2014-02-14  3:57   ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08  7:51 ` [PATCH 03/14] asmlinkage: Make jiffies visible Andi Kleen
2014-02-14  3:58   ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08  7:52 ` [PATCH 04/14] asmlinkage, pnp: Make variables used from assembler code visible Andi Kleen
2014-02-14  3:58   ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08  7:52 ` [PATCH 05/14] asmlinkage: Make lockdep_sys_exit asmlinkage Andi Kleen
2014-02-14  3:58   ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08  7:52 ` [PATCH 06/14] asmlinkage: Make trace_hardirq visible Andi Kleen
2014-02-10 11:24   ` Peter Zijlstra
2014-02-14  3:58   ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08  7:52 ` [PATCH 07/14] asmlinkage, mutex: Mark __visible Andi Kleen
2014-02-14  3:58   ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08  7:52 ` [PATCH 08/14] asmlinkage: Make main_extable_sort_needed visible Andi Kleen
2014-02-14  3:59   ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08  7:52 ` [PATCH 09/14] asmlinkage: Mark rwsem functions that can be called from assembler asmlinkage Andi Kleen
2014-02-14  3:59   ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08  7:52 ` Andi Kleen [this message]
2014-02-14  3:59   ` [tip:x86/asmlinkage] asmlinkage Make __stack_chk_failed and memcmp visible tip-bot for Andi Kleen
2014-02-08  7:52 ` [PATCH 11/14] asmlinkage, x86: Fix 32bit memcpy for LTO Andi Kleen
2014-02-14  3:59   ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08  7:52 ` [PATCH 12/14] asmlinkage: Make trace_hardirqs_on/off_caller visible Andi Kleen
2014-02-14  3:59   ` [tip:x86/asmlinkage] asmlinkage: Make trace_hardirqs_on/ off_caller visible tip-bot for Andi Kleen
2014-02-08  7:52 ` [PATCH 13/14] initconst: Fix initconst mistake in dcdbas Andi Kleen
2014-02-14  4:00   ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08  7:52 ` [PATCH 14/14] initconst, x86: Fix initconst mistake in ts5500 code Andi Kleen
2014-02-14  4:00   ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08  8:13 ` [PATCH 01/14] asmlinkage, kvm: Make kvm_rebooting visible Paolo Bonzini
2014-02-10 23:46 ` Andrew Morton
2014-02-14  3:57 ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391845930-28580-10-git-send-email-ak@linux.intel.com \
    --to=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox