From: Andi Kleen <ak@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org, x86@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 13/17] Kbuild, lto: Handle basic LTO in modpost
Date: Sat, 8 Feb 2014 09:01:17 +0100 [thread overview]
Message-ID: <1391846481-31491-13-git-send-email-ak@linux.intel.com> (raw)
In-Reply-To: <1391846481-31491-1-git-send-email-ak@linux.intel.com>
- Don't warn about LTO marker symbols. modpost runs before
the linker, so the module is not necessarily LTOed yet.
- Don't complain about .gnu.lto* sections
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
scripts/mod/modpost.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index f91dd45..63804a1 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -623,7 +623,10 @@ static void handle_modversions(struct module *mod, struct elf_info *info,
switch (sym->st_shndx) {
case SHN_COMMON:
- warn("\"%s\" [%s] is COMMON symbol\n", symname, mod->name);
+ if (!strncmp(symname, "__gnu_lto_", sizeof("__gnu_lto_")-1)) {
+ /* Should warn here, but modpost runs before the linker */
+ } else
+ warn("\"%s\" [%s] is COMMON symbol\n", symname, mod->name);
break;
case SHN_UNDEF:
/* undefined symbol */
@@ -849,6 +852,7 @@ static const char *section_white_list[] =
".xt.lit", /* xtensa */
".arcextmap*", /* arc */
".gnu.linkonce.arcext*", /* arc : modules */
+ ".gnu.lto*",
NULL
};
--
1.8.5.2
next prev parent reply other threads:[~2014-02-08 8:02 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 8:01 [PATCH 01/17] x86, lto: Disable LTO for the x86 VDSO Andi Kleen
2014-02-08 8:01 ` [PATCH 02/17] x86, lto: Disable fancy hweight optimizations for LTO v2 Andi Kleen
2014-02-08 18:52 ` H. Peter Anvin
2014-02-08 20:21 ` Andi Kleen
2014-02-08 21:43 ` H. Peter Anvin
2014-02-08 8:01 ` [PATCH 03/17] lto: Make asmlinkage __visible Andi Kleen
2014-02-14 4:30 ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-14 9:10 ` Borislav Petkov
2014-02-14 14:38 ` Andi Kleen
2014-02-08 8:01 ` [PATCH 04/17] lto, workaround: Add workaround for initcall reordering Andi Kleen
2014-02-14 4:30 ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08 8:01 ` [PATCH 05/17] lto: Handle LTO common symbols in module loader Andi Kleen
2014-02-12 1:04 ` Rusty Russell
2014-02-14 4:30 ` [tip:x86/asmlinkage] " tip-bot for Joe Mario
2014-02-20 23:11 ` Rusty Russell
2014-02-21 19:12 ` H. Peter Anvin
2014-02-21 22:37 ` Andi Kleen
2014-02-08 8:01 ` [PATCH 06/17] lto: Disable LTO for sys_ni Andi Kleen
2014-02-14 4:31 ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08 8:01 ` [PATCH 07/17] Kbuild, lto, workaround: Don't warn for initcall_reference in modpost Andi Kleen
2014-02-14 4:31 ` [tip:x86/asmlinkage] Kbuild, lto, workaround: Don' t " tip-bot for Andi Kleen
2014-02-08 8:01 ` [PATCH 08/17] Kbuild, lto: Drop .number postfixes " Andi Kleen
2014-02-14 4:31 ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08 8:01 ` [PATCH 09/17] Kbuild, lto: add ld-version and ld-ifversion macros Andi Kleen
2014-02-14 4:31 ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08 8:01 ` [PATCH 10/17] Kbuild, lto: Add a gcc-ld script to let run gcc as ld Andi Kleen
2014-02-14 4:31 ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08 8:01 ` [PATCH 11/17] Kbuild, lto: Disable LTO for asm-offsets.c Andi Kleen
2014-02-14 4:32 ` [tip:x86/asmlinkage] " tip-bot for Andi Kleen
2014-02-08 8:01 ` [PATCH 12/17] Kbuild, lto: Set TMPDIR for LTO Andi Kleen
2014-02-14 4:26 ` H. Peter Anvin
2014-02-14 15:37 ` Andi Kleen
2014-02-08 8:01 ` Andi Kleen [this message]
2014-02-14 4:32 ` [tip:x86/asmlinkage] Kbuild, lto: Handle basic LTO in modpost tip-bot for Andi Kleen
2014-02-08 8:01 ` [PATCH 14/17] Kbuild, lto: Add Link Time Optimization support Andi Kleen
2014-02-14 4:28 ` H. Peter Anvin
2014-02-14 14:36 ` Andi Kleen
2014-02-14 16:25 ` H. Peter Anvin
2014-02-08 8:01 ` [PATCH 15/17] Kbuild, lto: Add LTO build Documentation Andi Kleen
2014-02-08 8:01 ` [PATCH 16/17] lto: Mark spinlocks noinline when inline spinlocks are disabled Andi Kleen
2014-02-08 8:01 ` [PATCH 17/17] lto, module: Warn about modules that are not fully LTOed Andi Kleen
2014-02-12 1:13 ` Rusty Russell
2014-02-14 4:30 ` [tip:x86/asmlinkage] x86, lto: Disable LTO for the x86 VDSO tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391846481-31491-13-git-send-email-ak@linux.intel.com \
--to=ak@linux.intel.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox