From: Alexandre Courbot <acourbot@nvidia.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>
Subject: [PATCH 2/2] gpiolib: ACPI: remove gpio_to_desc() usage
Date: Sun, 9 Feb 2014 17:43:55 +0900 [thread overview]
Message-ID: <1391935435-29002-2-git-send-email-acourbot@nvidia.com> (raw)
In-Reply-To: <1391935435-29002-1-git-send-email-acourbot@nvidia.com>
gpio_to_desc() must die. Replace one of its usage by the
newly-introduced gpiochip_get_desc() function.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
Mika, can we have your review on this?
drivers/gpio/gpiolib-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 716ee98..b7db098 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -60,7 +60,7 @@ static struct gpio_desc *acpi_get_gpiod(char *path, int pin)
if (pin < 0 || pin > chip->ngpio)
return ERR_PTR(-EINVAL);
- return gpio_to_desc(chip->base + pin);
+ return gpiochip_get_desc(chip, pin);
}
static irqreturn_t acpi_gpio_irq_handler(int irq, void *data)
--
1.8.5.4
next prev parent reply other threads:[~2014-02-09 8:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 8:43 [PATCH 1/2] gpiolib: add gpiochip_get_desc() driver function Alexandre Courbot
2014-02-09 8:43 ` Alexandre Courbot [this message]
2014-02-10 10:06 ` [PATCH 2/2] gpiolib: ACPI: remove gpio_to_desc() usage Mika Westerberg
2014-02-12 16:16 ` Linus Walleij
2014-02-10 10:05 ` [PATCH 1/2] gpiolib: add gpiochip_get_desc() driver function Mika Westerberg
2014-02-12 9:41 ` Jean-Jacques Hiblot
2014-02-12 16:14 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391935435-29002-2-git-send-email-acourbot@nvidia.com \
--to=acourbot@nvidia.com \
--cc=jjhiblot@traphandler.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox