From: Paul Bolle <pebolle@tiscali.nl>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] [media] v4l: omap4iss: Remove VIDEO_OMAP4_DEBUG
Date: Sun, 09 Feb 2014 16:09:37 +0100 [thread overview]
Message-ID: <1391958577.25424.22.camel@x220> (raw)
Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4
camera interface - Build system") added a Kconfig entry for
VIDEO_OMAP4_DEBUG. But nothing uses that symbol.
This entry was apparently copied from a similar entry for "OMAP 3
Camera debug messages". But a corresponding Makefile line is missing.
Besides, the debug code also depends on a mysterious ISS_ISR_DEBUG
macro. This Kconfig entry can be removed.
Someone familiar with the code might be able to say what to do with the
code depending on the DEBUG and ISS_ISR_DEBUG macros.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested.
drivers/staging/media/omap4iss/Kconfig | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/media/omap4iss/Kconfig b/drivers/staging/media/omap4iss/Kconfig
index b9fe753..78b0fba 100644
--- a/drivers/staging/media/omap4iss/Kconfig
+++ b/drivers/staging/media/omap4iss/Kconfig
@@ -4,9 +4,3 @@ config VIDEO_OMAP4
select VIDEOBUF2_DMA_CONTIG
---help---
Driver for an OMAP 4 ISS controller.
-
-config VIDEO_OMAP4_DEBUG
- bool "OMAP 4 Camera debug messages"
- depends on VIDEO_OMAP4
- ---help---
- Enable debug messages on OMAP 4 ISS controller driver.
--
1.8.5.3
next reply other threads:[~2014-02-09 15:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 15:09 Paul Bolle [this message]
2014-02-10 14:13 ` [PATCH] [media] v4l: omap4iss: Remove VIDEO_OMAP4_DEBUG Laurent Pinchart
2014-02-10 15:13 ` Paul Bolle
2014-02-10 15:29 ` Laurent Pinchart
2014-02-11 11:17 ` [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag Paul Bolle
2014-02-11 12:38 ` Laurent Pinchart
2014-03-05 20:10 ` Mauro Carvalho Chehab
2014-03-05 23:50 ` Laurent Pinchart
2014-03-06 0:28 ` Joe Perches
2014-03-06 0:48 ` Laurent Pinchart
2014-03-06 1:00 ` Joe Perches
2014-03-06 1:27 ` Laurent Pinchart
2014-03-06 1:35 ` Joe Perches
2014-03-06 1:52 ` Laurent Pinchart
2014-03-06 3:25 ` Joe Perches
2014-03-06 10:55 ` Laurent Pinchart
2014-03-06 16:47 ` Joe Perches
2014-03-06 4:45 ` Greg Kroah-Hartman
2014-03-06 10:23 ` Paul Bolle
2014-03-06 11:00 ` Laurent Pinchart
2014-03-06 11:59 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391958577.25424.22.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox