Re: [PATCH 24/28] Remove DEPRECATED

Geert Uytterhoeven
2014-02-10T08:49:18Z

On Sun, Feb 9, 2014 at 9:21 PM, Richard Weinberger <richard@nod.at> wrote:
> Am 09.02.2014 21:15, schrieb Paul Bolle:
>> On Sun, 2014-02-09 at 21:04 +0100, Richard Weinberger wrote:
>>> Am 09.02.2014 20:38, schrieb Paul Bolle:
>>>> But now you've enabled a lot of stuff that, as far as I can tell, could
>>>> not have been built since v2.6.39.
>>>
>>> This is by design. If the code does not build/work it needs to be fixed or removed.
>>
>> If that was the design goal of this patch (and similar patches you've
>> sent) it would have been proper to at least say a few words along those
>> lines in the commit explanation.
>
> I assumed that every kernel developer is aware of that fact that unreachable/dead code
> should be removed.

Yes, it should be removed.

But that's not what you did. You did the Kconfig-equivalent of removing a
"#if 0" in a C source file, which causes havoc.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds