Re: [PATCH 24/28] Remove DEPRECATED

Guenter Roeck
2014-02-09T21:35:08Z

On 02/09/2014 12:04 PM, Richard Weinberger wrote:
> Am 09.02.2014 20:38, schrieb Paul Bolle:
>> On Sun, 2014-02-09 at 19:48 +0100, Richard Weinberger wrote:
>>> The symbol is an orphan, get rid of it.
>>>
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> ---
>>> arch/mn10300/Kconfig.debug | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/mn10300/Kconfig.debug b/arch/mn10300/Kconfig.debug
>>> index 94efb3e..af18047 100644
>>> --- a/arch/mn10300/Kconfig.debug
>>> +++ b/arch/mn10300/Kconfig.debug
>>> @@ -32,7 +32,7 @@ config KPROBES
>>>
>>> config GDBSTUB
>>> bool "Remote GDB kernel debugging"
>>> - depends on DEBUG_KERNEL && DEPRECATED
>>> + depends on DEBUG_KERNEL
>>
>> But now you've enabled a lot of stuff that, as far as I can tell, could
>> not have been built since v2.6.39.
>
> This is by design. If the code does not build/work it needs to be fixed or removed.
>

I could understand if you would replace DEPRECATED with BROKEN,
but causing a potentially large number of broken builds and
then leave it to others to clean up the resulting mess doesn't
make any sense to me and should, in my opinion, be rejected.

Guenter