Re: [PATCH 19/28] Remove SI4713

Hans Verkuil
2014-02-09T19:14:21Z

On 02/09/2014 07:47 PM, Richard Weinberger wrote:
> The symbol is an orphan, get rid of it.

NACK.

It's not an orphan, it's a typo. It should be I2C_SI4713.

Paul, Richard, let me handle this. I'll make a patch for this tomorrow (I believe
there was a report about a missing I2C dependency as well) and make sure it ends
up in a pull request for 3.14.

Regards,

Hans

>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/media/radio/si4713/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/radio/si4713/Kconfig b/drivers/media/radio/si4713/Kconfig
> index a7c3ba8..ed51ed0 100644
> --- a/drivers/media/radio/si4713/Kconfig
> +++ b/drivers/media/radio/si4713/Kconfig
> @@ -1,7 +1,6 @@
> config USB_SI4713
> tristate "Silicon Labs Si4713 FM Radio Transmitter support with USB"
> depends on USB && RADIO_SI4713
> - select SI4713
> ---help---
> This is a driver for USB devices with the Silicon Labs SI4713
> chip. Currently these devices are known to work.
> @@ -16,7 +15,6 @@ config USB_SI4713
> config PLATFORM_SI4713
> tristate "Silicon Labs Si4713 FM Radio Transmitter support with I2C"
> depends on I2C && RADIO_SI4713
> - select SI4713
> ---help---
> This is a driver for I2C devices with the Silicon Labs SI4713
> chip.
>