From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932709AbbJ3I2E (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Oct 2015 04:28:04 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:61084 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932151AbbJ3I17 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Oct 2015 04:27:59 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Jens Kuske <jenskuske@gmail.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Emilio =?ISO-8859-1?Q?L=F3pez?= <emilio@elopez.com.ar>,
        devicetree@vger.kernel.org,
        Vishnu Patekar <vishnupatekar0510@gmail.com>,
        linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
        linux-sunxi@googlegroups.com
Subject: Re: [PATCH v4 4/6] reset: sunxi: Add Allwinner H3 bus resets
Date: Fri, 30 Oct 2015 09:27:03 +0100
Message-ID: <13919923.o3Dj9msmoa@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1445964626-6484-5-git-send-email-jenskuske@gmail.com>
References: <1445964626-6484-1-git-send-email-jenskuske@gmail.com> <1445964626-6484-5-git-send-email-jenskuske@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:q7vFEQZqhZmDhdimsqLQnLuz3Ao0xX3X8WvFSQeu/7xjC+z/C2t
 bUWnhghB68X1SVt/W+zqRCzvsRGVvhjiTZZVeaVFlAQAxlyb4dAlBkMaZq9P6R4Wb4wjUjc
 sR+3YRxV7Ii23pnK/FuJpKS3F9trKL/ewPUJRBRkKdYODRSUq+nz0KdlXZTzkR9uMOXD5qb
 kFdabVT5obW5W40YYZNIw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:gZSpisAh278=:fTfv138OyD3rk5uUgay4wO
 AwnHYncPVovvdG2ZzZWJjJ6xrkqB0bMPvSBYuCZiz3g7dIi2RI+/8P3ntGWSEnJDsE1x4FnT9
 8PN4m5HQdNREObPlK5N7ou1pV8U1WqsQFHCYiv/EoEZa1vgz3h6gqhf/Cex9cR4fcAeKzf9J1
 gbfCahyQbVesg+EybEuqr2nY3Dy9JkuZ7hpIhuDSk4AJq1xnMDr9UfBc4BDiZxE7cLD+1b8rs
 uiD5JWEm0OVJOJywb3pbZ7/n5CXRxh0dYzVNX3vyac4ZcBmxSzLdlVTgtbShY0MPp2aBog556
 Ojb93/kRpZWaGAZemSGWNw9EyRnhA6mNTWK/6b+JrGU4rqOFWI7vLZJt3tvWCMmGxCq57LdJx
 rMnLT27jp8wVkytne4hNrDLURJonZ9LQpwnLoN9kFTQiEObFURewbPqdfvbw6OdWPtpuWJvkd
 RIUvrIzHHp5cc57Fon90+ui2Phb1RJBqEVYVfibZzIuW7ms0t67ZVjT8s496D8ubXqmcPbtQ1
 4zNWiEHY25OX3oPUcgC9GPvFBoJ2eYeMb6fnrU11Vi3R4DpVikV63Sdo2Z4bLd0U33o21nEkd
 LCV9XebLeHbY/l/Ngk8ZZIkBR+a2Rdc1GEHt88D1aFFWOUgaeygVOUTPT0Iy4urQthac1PWyB
 vaogCzg+kF6GekAJLV8DMFYN0wwRTA+/jxy+cMPJTlkUvwySKYfkqUWODZ7sMN0JTRVwClAIT
 NsWiRwtesXtm+ITQ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 27 October 2015 17:50:24 Jens Kuske wrote:
> 
> +static int sun8i_h3_bus_reset_xlate(struct reset_controller_dev *rcdev,
> +                                   const struct of_phandle_args *reset_spec)
> +{
> +       unsigned int index = reset_spec->args[0];
> +
> +       if (index < 96)
> +               return index;
> +       else if (index < 128)
> +               return index + 32;
> +       else if (index < 160)
> +               return index + 64;
> +       else
> +               return -EINVAL;
> +}
> +
> 

This looks like you are doing something wrong and should either
put the actual number into DT, or use a two-cell representation,
with the first cell indicating the block (0, 1 or 2), and the
second cell the index.

	Arnd