linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: [PATCH 4/8] perf top: Add --percentage option
Date: Mon, 10 Feb 2014 11:47:21 +0900	[thread overview]
Message-ID: <1392000446-14744-5-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1392000446-14744-1-git-send-email-namhyung@kernel.org>

The --percentage option is for controlling overhead percentage
displayed.  It can only receive either of "relative" or "absolute".

For more information, please see previous commit same thing done to
"perf report".

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/Documentation/perf-top.txt | 18 +++++++++++++++---
 tools/perf/builtin-top.c              | 16 ++++++++++++++++
 2 files changed, 31 insertions(+), 3 deletions(-)

diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
index cdd8d4946dba..0acf54f203f0 100644
--- a/tools/perf/Documentation/perf-top.txt
+++ b/tools/perf/Documentation/perf-top.txt
@@ -124,13 +124,16 @@ Default is to monitor all CPUS.
 	Show a column with the sum of periods.
 
 --dsos::
-	Only consider symbols in these dsos.
+	Only consider symbols in these dsos.  This option will affect the
+	percentage of the overhead column.  See --percentage for more info.
 
 --comms::
-	Only consider symbols in these comms.
+	Only consider symbols in these comms.  This option will affect the
+	percentage of the overhead column.  See --percentage for more info.
 
 --symbols::
-	Only consider these symbols.
+	Only consider these symbols.  This option will affect the
+	percentage of the overhead column.  See --percentage for more info.
 
 -M::
 --disassembler-style=:: Set disassembler style for objdump.
@@ -166,6 +169,15 @@ Default is to monitor all CPUS.
 	Do not show entries which have an overhead under that percent.
 	(Default: 0).
 
+--percentage::
+	Determine how to display the overhead percentage of filtered entries.
+	Filters can be applied by --comms, --dsos and/or --symbols options and
+	Zoom operations on the TUI (thread, dso, etc).
+
+	"relative" means it's relative to filtered entries only so that the
+	sum of shown entries will be always 100%. "absolute" means it retains
+	the original value before and after the filter is applied.
+
 INTERACTIVE PROMPTING KEYS
 --------------------------
 
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index ed99ec4a309f..a516e0389c5e 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1011,6 +1011,20 @@ parse_percent_limit(const struct option *opt, const char *arg,
 	return 0;
 }
 
+static int
+parse_percentage(const struct option *opt __maybe_unused, const char *arg,
+		 int unset __maybe_unused)
+{
+	if (!strcmp(arg, "relative"))
+		symbol_conf.filter_relative = true;
+	else if (!strcmp(arg, "absolute"))
+		symbol_conf.filter_relative = false;
+	else
+		return -1;
+
+	return 0;
+}
+
 int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
 {
 	int status = -1;
@@ -1114,6 +1128,8 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
 	OPT_STRING('u', "uid", &target->uid_str, "user", "user to profile"),
 	OPT_CALLBACK(0, "percent-limit", &top, "percent",
 		     "Don't show entries under that percent", parse_percent_limit),
+	OPT_CALLBACK(0, "percentage", NULL, "relative|absolute",
+		     "How to display percentage of filtered entries", parse_percentage),
 	OPT_END()
 	};
 	const char * const top_usage[] = {
-- 
1.7.11.7


  parent reply	other threads:[~2014-02-10  2:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10  2:47 [PATCHSET 0/8] perf tools: Update on filtered entries' percentage output (v4) Namhyung Kim
2014-02-10  2:47 ` [PATCH 1/8] perf tools: Count periods of filtered entries separately Namhyung Kim
2014-02-10  2:47 ` [PATCH 2/8] perf hists: Add support for showing relative percentage Namhyung Kim
2014-02-10  2:47 ` [PATCH 3/8] perf report: Add --percentage option Namhyung Kim
2014-02-20 10:39   ` Jiri Olsa
2014-02-24  6:37     ` Namhyung Kim
2014-02-10  2:47 ` Namhyung Kim [this message]
2014-02-20 10:44   ` [PATCH 4/8] perf top: " Jiri Olsa
2014-02-24  6:37     ` Namhyung Kim
2014-02-10  2:47 ` [PATCH 5/8] perf diff: " Namhyung Kim
2014-02-20 10:47   ` Jiri Olsa
2014-02-20 10:49   ` Jiri Olsa
2014-02-10  2:47 ` [PATCH 6/8] perf tools: Add hist.percentage config option Namhyung Kim
2014-02-20 11:01   ` Jiri Olsa
2014-02-24  6:41     ` Namhyung Kim
2014-02-10  2:47 ` [PATCH 7/7] perf tools: Show absolute percentage by default Namhyung Kim
2014-02-10  3:00   ` Namhyung Kim
2014-02-10  2:47 ` [PATCH 7/8] perf ui/tui: Add 'F' hotkey to toggle percentage output Namhyung Kim
2014-02-20 10:54   ` Jiri Olsa
2014-02-24  7:49     ` Namhyung Kim
2014-02-10  2:47 ` [PATCH 8/8] perf tools: Show absolute percentage by default Namhyung Kim
2014-02-20  1:00 ` [PATCHSET 0/8] perf tools: Update on filtered entries' percentage output (v4) Namhyung Kim
  -- strict thread matches above, loose matches on Subject: below --
2014-02-24  8:09 [PATCHSET 0/8] perf tools: Update on filtered entries' percentage output (v5) Namhyung Kim
2014-02-24  8:09 ` [PATCH 4/8] perf top: Add --percentage option Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392000446-14744-5-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).