Re: [PATCH] Blackfin: bf537: rename "CONFIG_ADT7310" and friends

[Paul Bolle <pebolle@tiscali.nl>]

On Thu, 2014-02-13 at 08:29 -0800, Guenter Roeck wrote:
> On 02/13/2014 02:31 AM, Paul Bolle wrote:
> > On Thu, 2014-02-13 at 10:57 +0100, Paul Bolle wrote:
> >> This issue is still present in v3.14-rc2. Guenter's suggestion is the
> >> easiest way out. Should I submit a trivial patch that just removes the
> >> dead code depending on never defined CONFIG_ADT7310 and
> >> CONFIG_ADT7310_MODULE?
> >
> 
> My suggestion was to remove the ifdefs, not the code, and if I
> understand the reply correctly that won't work because in that
> case multiple devices would be registered with the SPI core
> on the same SPI interface.

Then I misinterpreted your suggestion. But removing the dead code
remains the easiest way out, of course. (Note that the code has only
been dead since v3.8, ie only a year now.)

> > And that is probably also true for for CONFIG_ADT7410 and
> > CONFIG_ADT7410_MODULE. See https://lkml.org/lkml/2013/5/13/497 (and my
> > follow up to that message).
> 
> Both Jean and myself sent Reviewed-by/Acked-by feedback.
> Not being the maintainers, that is pretty much all we can do.
>  From there it is really up to the maintainer to accept
> or reject the patches.

Jean and you are included in (some of) the threads regarding a few
blackfin patches I sent last year. I forgot why you two are. Anyhow,
those patches were (mostly) ignored by the people working on blackfin.
The maintainer appears to be more responsive now. So I figured it might
be worthwhile to send reminders. Maybe I have more luck this time.


Paul Bolle