Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

Mark Brown
2014-02-15T10:10:03Z

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

On Fri, Feb 14, 2014 at 02:05:56PM +0100, Krzysztof Kozlowski wrote:
> On Thu, 2014-02-13 at 17:46 +0530, Yadwinder Singh Brar wrote:

> - low-power mode;
> - low-power mode controlled by PWREN;
> Although not all are present for each regulator.

What exactly is low power mode and how does it interact with the enable?
The name suggests it's a more efficient mode for use with low current
drain, is that right?

> A generic solution for operating mode of regulators (not only s2mps11
> and s5m8767) could cover all of these above or just a subset, for
> example regulator bindings could look like:
> - regulator-mode-suspend; /* PWR controls: on/off or low-power mode */
> - regulator-mode-low-power; /* Low power mode */

Those properties have awfully generic names and part of what I was
wondering above is if the low power mode maps onto the idle or standby
modes that the API defines? We don't cover those in the bindings yet
since they are unfortunately fuzzy but perhaps we need to do so.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]