linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Zhang <zhangwm@marvell.com>
To: <balbi@ti.com>, <gregkh@linuxfoundation.org>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Neil Zhang <zhangwm@marvell.com>
Subject: [PATCH 4/6] usb: gadget: mv_udc: check endpoint before queue dtd
Date: Mon, 24 Feb 2014 16:03:14 +0800	[thread overview]
Message-ID: <1393228996-14787-5-git-send-email-zhangwm@marvell.com> (raw)
In-Reply-To: <1393228996-14787-1-git-send-email-zhangwm@marvell.com>

There is a corner case that endpoint is disabled by system shutdown
between check ep->desc and hold spin lock in mv_ep_queue. In this
case ep->ep.desc will be NULL and occur kernel panic when access
it in build_dtd.

Signed-off-by: Neil Zhang <zhangwm@marvell.com>
---
 drivers/usb/gadget/mv_udc_core.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c
index d5a9bdf..a620cff 100644
--- a/drivers/usb/gadget/mv_udc_core.c
+++ b/drivers/usb/gadget/mv_udc_core.c
@@ -734,6 +734,14 @@ mv_ep_queue(struct usb_ep *_ep, struct usb_request *_req, gfp_t gfp_flags)
 
 	spin_lock_irqsave(&udc->lock, flags);
 
+	if (!ep->ep.desc) {
+		spin_unlock_irqrestore(&udc->lock, flags);
+		dev_info(&udc->dev->dev,
+			"%s is already disabled!\n", ep->name);
+		retval = -EINVAL;
+		goto err_unmap_dma;
+	}
+
 	/* build dtds and push them to device queue */
 	if (!req_to_dtd(req)) {
 		retval = queue_dtd(ep, req);
-- 
1.7.9.5


  parent reply	other threads:[~2014-02-24  8:03 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24  8:03 [PATCH 0/6] bug fix for mv_udc_core.c Neil Zhang
2014-02-24  8:03 ` [PATCH 1/6] usb: gadget: mv_udc: remove redundant pull up in udc_start Neil Zhang
2014-02-24  8:03 ` [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0 Neil Zhang
2014-02-25  1:18   ` Peter Chen
2014-02-25  4:13     ` Neil Zhang
2014-02-25  5:15       ` Peter Chen
2014-02-25  7:11         ` Neil Zhang
2014-02-25  7:46           ` Peter Chen
2014-02-25 18:12             ` Felipe Balbi
2014-02-26  1:48               ` Neil Zhang
2014-02-26  2:36                 ` Peter Chen
2014-02-26 15:20                   ` Felipe Balbi
2014-02-26 15:23                   ` Felipe Balbi
2014-02-27  3:30                     ` Peter Chen
2014-02-27 16:52                       ` Felipe Balbi
2014-02-27 18:05                       ` Fabio Estevam
2014-02-27 19:04                         ` Felipe Balbi
2014-02-26 15:19                 ` Felipe Balbi
2014-02-27  9:12                   ` Neil Zhang
2014-02-24  8:03 ` [PATCH 3/6] usb: gadget: mv_udc: clear corresponding interrupt when flush fifo Neil Zhang
2014-02-25  1:59   ` Peter Chen
2014-02-25  7:26     ` Neil Zhang
2014-02-24  8:03 ` Neil Zhang [this message]
2014-02-24  8:03 ` [PATCH 5/6] USB: gadget: mv_udc: workaroud for missing dTD Neil Zhang
2014-02-25  4:19   ` Peter Chen
2014-02-25  7:16     ` Neil Zhang
2014-02-25  7:22       ` Peter Chen
2014-02-24  8:03 ` [PATCH 6/6] USB: gadget: mv_udc: fix corner case for missiong dTD Neil Zhang
2014-02-24 10:31 ` [PATCH 0/6] bug fix for mv_udc_core.c Matthieu CASTET
2014-02-24 12:42   ` Neil Zhang
2014-02-25  4:17     ` Peter Chen
2014-02-25  7:18       ` Neil Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393228996-14787-5-git-send-email-zhangwm@marvell.com \
    --to=zhangwm@marvell.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).