From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 03/12] perf tools: Fix bison OUTPUT directories dependency
Date: Mon, 24 Feb 2014 16:56:31 -0300 [thread overview]
Message-ID: <1393271800-17505-4-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1393271800-17505-1-git-send-email-acme@infradead.org>
From: Jiri Olsa <jolsa@redhat.com>
The bison and flex C objects don't have dependency for creating output
directories.
This could lead to build failure if the one of those objects is picked
up by make to be build as the first one (reported by Arnaldo).
Also following make fails:
$ rm -rf /tmp/krava; mkdir /tmp/krava; make O=/tmp/krava util/pmu-bison.o
BUILD: Doing 'make -j4' parallel build
[ SNIP ]
BISON /tmp/krava/util/pmu-bison.c
FLAGS: * new build flags or prefix
bison: /tmp/krava/util/pmu-bison.output: cannot open: No such file or directory
make[1]: *** [/tmp/krava/util/pmu-bison.c] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [util/pmu-bison.o] Error 2
Adding bison objects dependency for output directories (flex objects
depends on bisons').
This fixies the make_util_pmu_bison_o_O make test.
Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1392805300-14610-3-git-send-email-jolsa@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile.perf | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 77b153fa23a5..5fedd6946f32 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -712,9 +712,15 @@ $(patsubst perf-%,%.o,$(PROGRAMS)): $(LIB_H) $(wildcard */*.h)
# we depend the various files onto their directories.
DIRECTORY_DEPS = $(LIB_OBJS) $(BUILTIN_OBJS) $(GTK_OBJS)
DIRECTORY_DEPS += $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)common-cmds.h
-$(DIRECTORY_DEPS): | $(sort $(dir $(DIRECTORY_DEPS)))
+# no need to add flex objects, because they depend on bison ones
+DIRECTORY_DEPS += $(OUTPUT)util/parse-events-bison.c
+DIRECTORY_DEPS += $(OUTPUT)util/pmu-bison.c
+
+OUTPUT_DIRECTORIES := $(sort $(dir $(DIRECTORY_DEPS)))
+
+$(DIRECTORY_DEPS): | $(OUTPUT_DIRECTORIES)
# In the second step, we make a rule to actually create these directories
-$(sort $(dir $(DIRECTORY_DEPS))):
+$(OUTPUT_DIRECTORIES):
$(QUIET_MKDIR)$(MKDIR) -p $@ 2>/dev/null
$(LIB_FILE): $(LIB_OBJS)
--
1.8.1.4
next prev parent reply other threads:[~2014-02-24 19:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 19:56 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
2014-02-24 19:56 ` [PATCH 01/12] perf tests: Fix *.o make tests Arnaldo Carvalho de Melo
2014-02-24 19:56 ` [PATCH 02/12] perf tests: Add pmu-bison.o make test Arnaldo Carvalho de Melo
2014-02-24 19:56 ` Arnaldo Carvalho de Melo [this message]
2014-02-24 19:56 ` [PATCH 04/12] perf tools: Factor features display code Arnaldo Carvalho de Melo
2014-02-24 19:56 ` [PATCH 05/12] perf tools: Add variable display for VF make output Arnaldo Carvalho de Melo
2014-02-24 19:56 ` [PATCH 06/12] perf tools: Warn the user about how to enable libunwind support Arnaldo Carvalho de Melo
2014-02-24 19:56 ` [PATCH 07/12] perf tools: Add feature check for libdw dwarf unwind Arnaldo Carvalho de Melo
2014-02-24 19:56 ` [PATCH 08/12] perf tools: Add libdw DWARF post unwind support Arnaldo Carvalho de Melo
2014-02-24 19:56 ` [PATCH 09/12] perf tools: Setup default dwarf post unwinder Arnaldo Carvalho de Melo
2014-02-24 19:56 ` [PATCH 10/12] perf tests: Add NO_LIBDW_DWARF_UNWIND make test Arnaldo Carvalho de Melo
2014-02-24 19:56 ` [PATCH 11/12] perf symbols: Check return value of filename__read_debuglink() Arnaldo Carvalho de Melo
2014-02-24 19:56 ` [PATCH 12/12] perf symbols: Check compatible symtab type before loading dso Arnaldo Carvalho de Melo
2014-02-27 11:46 ` [GIT PULL 00/12] perf/core improvements and fixes Ingo Molnar
2014-02-27 12:02 ` Jiri Olsa
2014-02-27 12:30 ` Ingo Molnar
2014-02-27 12:40 ` Jiri Olsa
2014-02-27 12:45 ` Ingo Molnar
2014-02-27 12:04 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393271800-17505-4-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).