From: Joe Perches <joe@perches.com>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: Monam Agarwal <monamagarwal123@gmail.com>,
Ian Abbott <ian.abbott@mev.co.uk>,
"hsweeten@visionengravers.com" <hsweeten@visionengravers.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
Date: Tue, 25 Feb 2014 01:59:25 -0800 [thread overview]
Message-ID: <1393322365.8716.3.camel@joe-AO722> (raw)
In-Reply-To: <530C666B.6080900@mev.co.uk>
On Tue, 2014-02-25 at 09:46 +0000, Ian Abbott wrote:
> On 2014-02-24 16:49, Monam Agarwal wrote:
[]
> > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
[]
> > @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev,
> > async->cmd.data = NULL;
> > /* load channel/gain list */
> > async->cmd.chanlist = memdup_user(user_chanlist,
> > - async->cmd.chanlist_len * sizeof(int));
> > + async->cmd.chanlist_len
> > + * sizeof(int));
>
> The `*` operator should go at the end of the line according to the
> CodingStyle.
I don't believe there's a CodingStyle guide for this.
Another way to do this is to move the memdup_user to
a separate line like:
async->cmd_chanlist =
memdup_user(user_chanlist,
async->cmd.chanlist_len * sizeof(int));
but I'm not bothered by the existing > 80 column use.
next prev parent reply other threads:[~2014-02-25 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 16:49 [PATCH] Staging: comedi: Fix line length exceeding 80 characters Monam Agarwal
2014-02-25 9:46 ` Ian Abbott
2014-02-25 9:59 ` Joe Perches [this message]
2014-02-25 11:05 ` Dan Carpenter
2014-02-25 11:48 ` Joe Perches
2014-02-25 14:36 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393322365.8716.3.camel@joe-AO722 \
--to=joe@perches.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=monamagarwal123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox