Re: [PATCH v4 4/9] Input: pmic8xxx-keypad - Migrate to DT

Stephen Boyd
2014-02-28T18:29:18Z

On 02/27, Josh Cartwright wrote:
> Looks good, with the exception of one thing...
>
> On Thu, Feb 27, 2014 at 05:55:15PM -0800, Stephen Boyd wrote:
> > The driver is only supported on DT enabled platforms. Convert the
> > driver to DT so that it can probe properly.
> >
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> > drivers/input/keyboard/pmic8xxx-keypad.c | 150 ++++++++++++++++++-------------
> > @@ -471,50 +514,27 @@ static void pmic8xxx_kp_close(struct input_dev *dev)
> > */
> > static int pmic8xxx_kp_probe(struct platform_device *pdev)
> > {
> [..]
> > - keymap_data = pdata->keymap_data;
> > - if (!keymap_data) {
> > - dev_err(&pdev->dev, "no keymap data supplied\n");
> > - return -EINVAL;
> > - }
> > + repeat = !of_property_read_bool(pdev->dev.of_node,
> > + "linux,input-no-autorepeat");
> > + wakeup = !of_property_read_bool(pdev->dev.of_node,
> > + "linux,keypad-wakeup");
>
> I don't think you mean to invert this.
>

Good catch. Thanks.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,