From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tomasz Figa <t.figa@samsung.com>
Subject: Re: [PATCH 0/4] mfd: sec: Add support for S2MPS14
Date: Fri, 28 Feb 2014 12:05:26 +0100 [thread overview]
Message-ID: <1393585526.31997.1.camel@AMDC1943> (raw)
In-Reply-To: <20140228104927.GB31720@lee--X1>
On Fri, 2014-02-28 at 10:49 +0000, Lee Jones wrote:
> > Few days ago I sent patches adding support for S2MPS14 device to the
> > sec-core/s2mps11 drivers. These patches were rather large as they covered
> > multiple subsystems so I decided to split everything into smaller, separate
> > patches.
> >
> > The original patchset (version 3) can be found here:
> > http://thread.gmane.org/gmane.linux.kernel.samsung-soc/27194/focus=1649217
> >
> > This patchset is a small subset of the patchset related to the MFD core
> > driver. It adds support for the S2MPS14 device only to the MFD core driver.
> > I already obtained acks from Lee Jones during previous reviews.
> >
> > The patchset is based on current Linus' tree *with* patch:
> > mfd: sec-core: Fix possible NULL pointer dereference when i2c_new_dummy error
> > (which is already in Lee Jones' MFD tree)
>
> Can all of these patches be applied as they are?
>
> Is anything going to break as a result?
Yes, they can be applied as they are. That was the reason behind
splitting everything. Nothing should break, as far as I reviewed this
and tested.
Best regards,
Krzysztof
>
> > Krzysztof Kozlowski (4):
> > mfd: sec: Add maximum RTC register for regmap config
> > mfd: sec: Select different RTC regmaps for devices
> > mfd: sec: Use consistent S2MPS11 RTC alarm interrupt indexes
> > mfd: sec: Add support for S2MPS14
> >
> > drivers/mfd/sec-core.c | 57 ++++++++++++-
> > drivers/mfd/sec-irq.c | 97 ++++++++++++++++++++--
> > include/linux/mfd/samsung/core.h | 1 +
> > include/linux/mfd/samsung/irq.h | 31 ++++++-
> > include/linux/mfd/samsung/rtc.h | 57 +++++++++++--
> > include/linux/mfd/samsung/s2mps14.h | 152 +++++++++++++++++++++++++++++++++++
> > 6 files changed, 378 insertions(+), 17 deletions(-)
> > create mode 100644 include/linux/mfd/samsung/s2mps14.h
> >
>
next prev parent reply other threads:[~2014-02-28 11:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 10:41 [PATCH 0/4] mfd: sec: Add support for S2MPS14 Krzysztof Kozlowski
2014-02-28 10:41 ` [PATCH 1/4] mfd: sec: Add maximum RTC register for regmap config Krzysztof Kozlowski
2014-02-28 10:41 ` [PATCH 2/4] mfd: sec: Select different RTC regmaps for devices Krzysztof Kozlowski
2014-02-28 10:41 ` [PATCH 3/4] mfd: sec: Use consistent S2MPS11 RTC alarm interrupt indexes Krzysztof Kozlowski
2014-02-28 10:41 ` [PATCH 4/4] mfd: sec: Add support for S2MPS14 Krzysztof Kozlowski
2014-02-28 10:49 ` [PATCH 0/4] " Lee Jones
2014-02-28 11:05 ` Krzysztof Kozlowski [this message]
2014-02-28 11:11 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393585526.31997.1.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox